Coder Social home page Coder Social logo

Comments (3)

nielsfaber avatar nielsfaber commented on May 26, 2024

The proposed change involves extending the alarmo/event payload to include a "DISARMED" status when the alarm system is disarmed.

The disarmed status update is already visible in the state topic.
The only reason I see for adding this to the event topic is to send out contextual info.
Your request seems to hint at this but you don't make it very clear that is what you're looking for.

"timestamp": "2023-12-28T12:34:56",
"additional_data": "[USER]"

Sending such contextual information could be considered.
However, for sake of consistency this would have to be added to the other events as well.
I think the field additional_data should be renamed to user in this case, with the name of the user as payload.

What are your thoughts about this?
Note that all the data which is currently sent via the event topic is listed here.

from alarmo.

ervede avatar ervede commented on May 26, 2024

The proposed change involves extending the alarmo/event payload to include a "DISARMED" status when the alarm system is disarmed.

The disarmed status update is already visible in the state topic. The only reason I see for adding this to the event topic is to send out contextual info. Your request seems to hint at this but you don't make it very clear that is what you're looking for.

In response to your concerns about clarity, I want to emphasize that the primary motivation behind this proposal is to enhance the user experience for Node-Red users. The idea is that by including the "DISARMED" status directly in the event payload, Node-Red users could streamline their integration process, as they would only need to listen to the alarmo/event payload.

"timestamp": "2023-12-28T12:34:56",
"additional_data": "[USER]"

Sending such contextual information could be considered. However, for sake of consistency this would have to be added to the other events as well. I think the field additional_data should be renamed to user in this case, with the name of the user as payload.

What are your thoughts about this? Note that all the data which is currently sent via the event topic is listed here.

In the spirit of consistency, I'd like to propose an alternative naming convention that aligns with your suggestion. Instead of using user, we could consider using changed_by as the field name.

from alarmo.

github-actions avatar github-actions commented on May 26, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

from alarmo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.