Comments (11)
@RackReaver At the moment there are no tests for the cli, but even then, it must be updated/adapted to the click syntax. I implemented the first simple version using argparse, which had limitations and this is exactly one of the reasons why I want to switch to click.
If you want to give it a try, I would happily review and eventually update your PR. You don't have to be familiar with ML, the cli code has nothing to do with ML, it's just python.
from igel.
Hi. Adding my 2 cents: maybe https://github.com/google/python-fire can help speed up the process :)
from igel.
@nidhaloff Could you please assign the issue under me, I have begun working on rewriting the code.
from igel.
I use docopt for most of my projects now as click is usually overkill for what I need.
Based on what I see I think click is probably going to be your best option for your project as it has great modularity.
from igel.
@rmallof @RackReaver I'm not familiar with the two packages but thanks for the suggestion.
Yes I think click is a good choice for igel. Maybe typer would be even better but I'm not sure. I must check it out but it is also based on click and has similar syntax so that's the advantage
from igel.
I'm not super familiar with ML but I'd be willing to give converting this a whirl. Do you have existing tests for the cli to ensure nothing is missed?
from igel.
Hi @nidhaloff, I am new to open source and would like to start working on it. I would try to replace argparse with click in cli.py
from igel.
@nidhaloff can u please share what were the issues you faced with argparse and why we need to rewrite it in click maybe I can fix that in argparse itself.
from igel.
@akshaynarisetti I don't have to assign you the issue. Just work on it and make a PR. Many people told me in the past that they started working on it, but I still did not receive any PR from them, so I will not assign the issue to anyone. Just make a PR when you are done.
@kuspia there are no issues with argparse. Click is just convenient to use, the code would be cleaner. I also like the click group feature, where you can group many sub commands under one parent command https://click.palletsprojects.com/en/1.x-maintenance/api.html#click.option
If you have something in mind that you can improve using argparse, then create an issue for it and make a PR ;)
from igel.
Hi @nidhaloff, I have wrote something for command line arguments using click. I am still not sure how to integrate it and would really appreciate some suggestions. You can access the code from here https://github.com/GouravWadhwa/igel/blob/master/igel/click_cli.py.
from igel.
Hi @nidhaloff kindly check #89 it really enhances the cli.py using click version, I was working on it, if you will consider it, it will be my pleasure.
from igel.
Related Issues (20)
- Add auto ML support HOT 2
- Suggestions for a better and evtl faster logging
- CatBoost Classification and Regression feature
- Installation Error importlib_metadata
- Docs need different path to images HOT 1
- Clustering doesn't work. HOT 2
- Let's discuss how are you using igel and which updates/features would you rather see in the future HOT 13
- Is there any function to support me to export Python code after igel training? HOT 3
- Can't get it working like in Quick-Start HOT 6
- Inviting maintainers/contributors to the project HOT 7
- Rest Api HOT 2
- Export ONNX
- igel serve, example call and result in igel documentation. HOT 3
- Contributing Guide HOT 2
- Add CNN support HOT 2
- Add RNN/LSTM support HOT 3
- Add K-Medoids Support HOT 1
- ImportError exception handling routine cannot import utils
- Add K-Medians support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from igel.