Coder Social home page Coder Social logo

Comments (5)

nicolasgoutaland avatar nicolasgoutaland commented on May 27, 2024

Hi,
thanks for the suggestion. I will have a look at this.
Modifying updatedContentString method may introduce some incompatibilities with existing custom tags, but I will find a way.
Just one question, why are you dividing bounds dimensions by 2 ?
Regards,

from gonmarkupparser.

JDongKhan avatar JDongKhan commented on May 27, 2024

I'm sorry,it's Screen density.
I just write for test!

Modify:
CGFloat scale = [UIScreen mainScreen].scale;
attch.bounds = CGRectMake(0, 0, image.size.width/scale, image.size.height/scale);

from gonmarkupparser.

JDongKhan avatar JDongKhan commented on May 27, 2024

You just need to modifying computeFinalExtractedString method to support NSAttributedString value.
And I think the GONImageMarkup class will not affect other classes or custom tags!

Above is my suggestion.TKS!

from gonmarkupparser.

nicolasgoutaland avatar nicolasgoutaland commented on May 27, 2024

Hi, I'm working on it. Have a look in https://github.com/nicolasgoutaland/GONMarkupParser/tree/feature-images

Regards

from gonmarkupparser.

nicolasgoutaland avatar nicolasgoutaland commented on May 27, 2024

Any feedback on the feature ?
Regards

from gonmarkupparser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.