Link support about gonmarkupparser

[nicolasgoutaland]

Hi,
Are you talking about the anchor sample, or the custom markups sample ?

[andyfitter]

Ah, sorry, I should have been more clear - Its the Anchor sample on the develop branch.

[nicolasgoutaland]

Ok. I've merged the develop in master this morning, but I didn't update the sample, my bad.
Working on it.

[nicolasgoutaland]

You can check the "Custom markups" sample, that should works.
To be sure that anchors tags are working, check that you are displaying your attributed string in a UITextView and that your delegate is correctly set.

[nicolasgoutaland]

Just pushed an updated sample. Let me know if everything is ok.

[andyfitter]

Thanks for that - The sample works fine now. Do you know of any reason that the Anchor code would not work on iOS 7.0? Both your sample app (If adjusted to allow iOS 7) and my code render the links fine, but the delegate method never gets called.

Andrew Fitter
[email protected]

On 11 Feb 2015, at 18:43, Nicolas Goutaland [email protected] wrote:

Just pushed an updated sample. Let me know if everything is ok.

—
Reply to this email directly or view it on GitHub #3 (comment).

[nicolasgoutaland]

This is strange. I have no problem on an iOS 7.1 simulator. Cannot test under iOS7.0 for now.

Are you using Interface Builder to configure your UITextView, or did you configure it by code ?
Have you tried following :

• implement other delegate methods, and check if they are called or not
• set the delegate manually
• set UITextView configuration manually

     _resultTextView.editable   = NO;
    _resultTextView.selectable = YES;

Let me know if it solves your problem.

[andyfitter]

Hi. Sorry if I wasn't clear - 7,1 and 8.x work fine, but 7.0 doesn't work. I wondered if you knew any reason why 7.1 would work but not 7.0

I might be able to change the app to support 7.1 upwards and all will be ok.

Thanks.

On 11 Feb 2015, at 9:15 pm, Nicolas Goutaland [email protected] wrote:

This is strange. I have no problem on an iOS 7.1 simulator. Cannot test under iOS7.0 for now.

Are you using Interface Builder to configure your UITextView, or did you configure it by code ?
Have you tried following :

implement other delegate methods, and check if they are called or not
set the delegate manually
set UITextView configuration manually ``` _resultTextView.editable = NO; _resultTextView.selectable = YES;

Let me know if it solves your problem.
—
Reply to this email directly or view it on GitHub.

[nicolasgoutaland]

Ok. Did you try to implements other delegate methods ? Are they called ?
Have you tried to configure your textview editable / selectable / delegate properties by code ?
This is the only reason I could find, that xib might by misinterpreted.

[nicolasgoutaland]

Seems to be a problem with NSTextAttachment in iOS 7.0.
Working on a fix.

[andyfitter]

Great, thanks.

Andrew Fitter
[email protected]

On 12 Feb 2015, at 10:47, Nicolas Goutaland [email protected] wrote:

Seems to be a problem with NSTextAttachment in iOS 7.0.
Working on a fix.

—
Reply to this email directly or view it on GitHub #3 (comment).

[nicolasgoutaland]

Just pushed a fix in the develop branch. Can you try the sample on iOS 7.0 ?

If my guess is correct, the delegate method to implement is - (BOOL)textView:(UITextView *)textView shouldInteractWithURL:(NSURL *)URL inRange:(NSRange)characterRangenow.

[andyfitter]

Seems to work ok on all my test devices - iOS 7.0 and upwards

Andrew Fitter
[email protected]

On 12 Feb 2015, at 13:43, Nicolas Goutaland [email protected] wrote:

Just pushed a fix in the develop branch. Can you try the sample on iOS 7.0 ?

If my guess is correct, the delegate method to implement is - (BOOL)textView:(UITextView *)textView shouldInteractWithURL:(NSURL *)URL inRange:(NSRange)characterRangenow.

—
Reply to this email directly or view it on GitHub #3 (comment).

[nicolasgoutaland]

Great, Merging it to master, updating Pod and Doc.
Thanks for the bug report.