network component only allows static class list about vue-social-sharing

[nicolasbeauvais]

Nice catch 👍 it should be fixed in 2.2.10

[tmorehouse]

I noticed one other "caveat" when using inline-templates. The "scope" of anything in the inline-template is that of the parent (the component with the inline-template prop). If one needs to reference a computed property from their own component (in my case calculating a set of classes), one needs to reference $parent:

<template>
  <div>
    <social-sharing ... inline-template>
      <network network="facebook" :class="$parent.myClasses">Facebook</network>
      <network network="twitter" :class="$parent.myClasses">Twitter</network>
    </social-sharing>
  </div>
</template>

<script>
export default {
  computed: {
    myClasses() {
      return ['btn', 'btn-primary']
    }
  }
}
</script>

Might be worth noting in the documentation. (the Vue.js documentation is not overly clear on the scope of inline-template https://vuejs.org/v2/guide/components.html#Inline-Templates)

[tmorehouse]

You may want to consider using this library to handle merging of the context.data in functional components:

https://github.com/alexsasharegan/vue-functional-data-merge

We use this extensively in our functional components

[nicolasbeauvais]

Thank you for the PR, the change has been tagged in https://github.com/nicolasbeauvais/vue-social-sharing/releases/tag/v2.2.9

The vue-functional-data-merge library could indeed be a nice addition to vue-social-sharing

[tmorehouse]

Yeah vue-functional-data-merge works quite well when merging context.data with additional attributes, etc.

We use it a lot in our functional components for Bootstrap-Vue (it was written by one of our members)

[tmorehouse]

Hmmm, I just upgraded to 2.2.9 and v-bound classes are still not working. only classes specified as a static string.

[tmorehouse]

These lines: https://github.com/nicolasbeauvais/vue-social-sharing/blob/master/src/social-sharing-network.js#L16-L18

Do not appear in the dist files:
https://github.com/nicolasbeauvais/vue-social-sharing/blob/master/dist/vue-social-sharing.js#L58-L61

It doesn't appear that the dist files were updated

[tmorehouse]

BTW... all is working great now... except one can't pass a title prop (or other arbitrary attributes).

Object.assign((), context.data.attrs, {.. custom data attrs here }) would work well for merging attributes, except for IE, which needs a polyfill for Object.assign :(