Feature Request: Expose attemptNo or allow code to be specified in beforeAttempts/afterAttempts about protractor-flake

[rasjani]

I guess my pr will address this as it will call protractor with --params.flake.iteration which then can be used in via browser.params.flake.iteration.

[NickTomlin]

I think this makes a lot of sense, could you give me some pseudocode for how you'd use this? This could potentially be a param that we pass to protractor or an env variable that we set. I'd want to make sure we can do it in a way that wouldn't clash with protractor config.

[Tom-Hudson]

Glad you agree! To be honest I get a little twitchy with the thought of the attempt count being a Node environment variable as this value would persist if flake got stopped etc. It would also cause problems for shared CI/build servers with multiple builds unless you make the environment variable unique to the instance of flake running (not sure that's a good idea either)? In my opinion, it would be better as a param or just accessible from a flake instance:

onPrepare: () => { 
    if(flake.attemptNo == 1) {
        // Do cleanup
    }
}

But as I mentioned before, I would also be happy to put my code in functions passed to the protractor-flake config like so:

protractorFlake({
    parser: 'standard'
}, function(status, output) {
    process.exit(status);
}, function() {
    //beforeAttempts
}, function() {
    //afterAttempts
})

But the obvious drawback with the latter is that no 'protractor or jasmine stuff' will be available for use in either function. Also, if you go with this option, it would be nice if the functions could be callback managed (or accept a promised function) so time consuming operations can be performed synchronously (sorry for adding complexity).

Thanks!

[Tom-Hudson]

@rasjani - yes it would! If @NickTomlin is happy then I would link the PR so this issue can be closed.

[rasjani]

#88

And its also already released.

[NickTomlin]

@rasjani thanks for reporting back here and for your PR! I'm going to go ahead and close this issue 😄