Coder Social home page Coder Social logo

Comments (3)

nh3 avatar nh3 commented on September 28, 2024

Thanks for your feedback. The intention of this package is to give easy access to those code to replicate CellRanger's cell calling behaviour. So whether the behaviour matches exactly that of the R implementation was not given priority. In this particular case, find_nonambient_barcodes() finds additional non-ambient barcodes, which is the behaviour of this function in CellRanger. The reason I didn't further wrap the barcode merging part is that it's trivial for the user to do so, and it allows users to inspect the returned p values to choose an appropriate cutoff which provides more flexibility than just returning a set of barcodes.

from emptydrops.

CowanCS1 avatar CowanCS1 commented on September 28, 2024

Fair enough, and I can understand why CellRanger would not want to evaluate and possibly exclude cell barcodes included with the previous method (even though this could perform poorly in some edge cases).

It would be very helpful if you add the description above to the readme, as the current description relies on knowing the details of CellRanger's emptydrops implementation. If the user doesn't have this knowledge a priori, they have to dig through the CellRanger code to understand that this is the expected behavior.

from emptydrops.

nh3 avatar nh3 commented on September 28, 2024

README updated in 45330a9
Thank you for your feedback and suggestion!

from emptydrops.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.