Coder Social home page Coder Social logo

Event names cannot contain dashes about ngvue HOT 7 CLOSED

ngvue avatar ngvue commented on July 19, 2024 1
Event names cannot contain dashes

from ngvue.

Comments (7)

pcable avatar pcable commented on July 19, 2024 3

I'm also having this issue. The callback in your case is being registered as somethingHappened however vue lowercases all event name when its going to call the callback so it never finds it. I'm trying to create a patch

from ngvue.

nicolaspayot avatar nicolaspayot commented on July 19, 2024

@erickwilder well, you can listen to v-on-something-happened on a <vue-component> tag if the event you emit is using camel case syntax:

this.$emit('somethingHappened')

We can change this behaviour to allow events to be emitted with kebab case syntax, however this would introduce a breaking change.

from ngvue.

erickwilder avatar erickwilder commented on July 19, 2024

The problem is that it goes against Vue's recommendation of aways emitting events in kebab-case. In our codebase we try to normalize all events following that convention as well

from ngvue.

erickwilder avatar erickwilder commented on July 19, 2024

By the way. Do we really need to introduce a breaking change? We could simply allow both

from ngvue.

nicolaspayot avatar nicolaspayot commented on July 19, 2024

I guess we could allow both syntaxes for event names but it would register twice the event callback, for each event... It might bring unnecessary performance drawbacks for an app with lots of components, with lots of events. I'd rather introduce a breaking change.

from ngvue.

realmerx avatar realmerx commented on July 19, 2024

Hello, I also hit the same problem and there seems to be a fork with this fixed (did not test this but code seems good): pcable@9974801.

I think it would be possible to have kebab case by default and also introduce a setting that one could set to send events as camel case to reduce breaking change problems.

One hacky way to hack around this is to override $emit method when creating vue constructor function for component that would be used inside angularjs:

var VueCompConst2 = Vue.extend(Object.assign({}, vueComponent, {
    created: function() {
        this.oldEmit = this.$emit;
        this.$emit = function(eventName) {
            eventName = eventName.split('-').map((p, i) => (i > 0 ? p.charAt(0).toUpperCase() : p.charAt(0)) + p.slice(1)).join('')
            this.oldEmit(eventName);
        }
    }
}));

from ngvue.

nicolaspayot avatar nicolaspayot commented on July 19, 2024

This pull request #83 should fix the issue. Please, feel free to review it 😉

from ngvue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.