Comments (7)
I'm also having this issue. The callback in your case is being registered as somethingHappened
however vue lowercases all event name when its going to call the callback so it never finds it. I'm trying to create a patch
from ngvue.
@erickwilder well, you can listen to v-on-something-happened
on a <vue-component>
tag if the event you emit is using camel case syntax:
this.$emit('somethingHappened')
We can change this behaviour to allow events to be emitted with kebab case syntax, however this would introduce a breaking change.
from ngvue.
The problem is that it goes against Vue's recommendation of aways emitting events in kebab-case. In our codebase we try to normalize all events following that convention as well
from ngvue.
By the way. Do we really need to introduce a breaking change? We could simply allow both
from ngvue.
I guess we could allow both syntaxes for event names but it would register twice the event callback, for each event... It might bring unnecessary performance drawbacks for an app with lots of components, with lots of events. I'd rather introduce a breaking change.
from ngvue.
Hello, I also hit the same problem and there seems to be a fork with this fixed (did not test this but code seems good): pcable@9974801.
I think it would be possible to have kebab case by default and also introduce a setting that one could set to send events as camel case to reduce breaking change problems.
One hacky way to hack around this is to override $emit method when creating vue constructor function for component that would be used inside angularjs:
var VueCompConst2 = Vue.extend(Object.assign({}, vueComponent, {
created: function() {
this.oldEmit = this.$emit;
this.$emit = function(eventName) {
eventName = eventName.split('-').map((p, i) => (i > 0 ? p.charAt(0).toUpperCase() : p.charAt(0)) + p.slice(1)).join('')
this.oldEmit(eventName);
}
}
}));
from ngvue.
This pull request #83 should fix the issue. Please, feel free to review it 😉
from ngvue.
Related Issues (20)
- Support for composition api? HOT 2
- .sync modifier HOT 2
- Vue3 support HOT 6
- Support multiple children in <slot>
- How to listen to broadcasted event from angular components into Vue component? HOT 4
- Vue component not rendering on IE HOT 1
- Vue-apollo provider doesn't work
- How to use Vue.js provide/inject with ngVue?
- Quirk Mode doesn't work.
- Specify `module` to `build/index.esm.js` in `package.json` to support ESM import HOT 2
- Incorrect main/module/exports in `package.json` in v2.1.1 HOT 2
- Mount Vue in ShadowDOM HOT 1
- Plugins do not work with Webpack 5 HOT 4
- Time to remove that deprecation message? HOT 4
- Update to the Vuex store does not trigger update in the components in debug mode. HOT 2
- `this.$store` is undefined after migration to wepback5 HOT 8
- how to re render a vue component with ngVue HOT 3
- Error: ngVue components must have a parent tag or they will not render HOT 1
- Maintainers needed
- v-directive not updating value
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngvue.