class and style attributes not merged down onto Vue component root about ngvue

[nlitwin]

Hi @pkaminski, you are correct that I explicitly excluded them. The reason I did that was because class and style are excluded from the attributes that make up $attrs. I believe if you want to make class and style also pass down to the Vue component, you would need to merge the values and potentially add them in addition to directives, props, on, and attrs here.

<Component {...{ directives }} {...{ props: reactiveData._v.props, on, attrs: reactiveData._v.attrs }}>
  { <span ref="__slot__" /> }
</Component>

I think you're right though that this is missing functionality, and a PR is probably needed to add the ability to pass class and style. I would wait for confirmation from the library authors though 😄

[nicolaspayot]

I don't see any reason not to do it! Of course these attributes should not be passed down if the inheritAttrs property is set to false, in the Vue component.

Please, go for it 😄

[pkaminski]

Cool, I'll give it a try tomorrow! Note that AFAICT inheritAttrs is explicitly documented not to affect class and style, though.

[nicolaspayot]

Oh, right. My mistake!

[pkaminski]

PR #69 is up. It took me approximately forever to figure out that I needed an extra root digest run to settle the dynamic class values! But the rest was straightforward.