Coder Social home page Coder Social logo

Comments (5)

AnnAddicks avatar AnnAddicks commented on September 28, 2024 1

Sure, I'd be happy to work on it; earliest time I would be able to push code would be Sunday evening.

from docx.

AnnAddicks avatar AnnAddicks commented on September 28, 2024

+1 for a replace header text.

I'd be happy to help with some initial direction.

from docx.

nguyenthenguyen avatar nguyenthenguyen commented on September 28, 2024

Sorry for a long time I'm not watching this repository. @AnnAddicks Could you add replace footer and some unit test ?

from docx.

AnnAddicks avatar AnnAddicks commented on September 28, 2024

Hi @nguyenthenguyen,
I just sat down to look at the footers and noticed a change to the ReplaceHeader function. If we are taking a user input for how many replaces should be done, is that per header or total? With the new changes that limits the number of changes to per header because we don't keep track of how many times it has been changed inside the loop. That is why initially I had it to not allow the user to pick a number.

I can make the footer code similar to what you have changed, but wanted to point this out. It would be a PITA to keep track per header since Replace doesn't return a count and considering some headers are for even pages and others for odd pages...I really didn't want to go down that rabbit hole.

from docx.

nguyenthenguyen avatar nguyenthenguyen commented on September 28, 2024

@AnnAddicks You are right! Because we can have mutiple header, footer file. You can remove num params on ReplaceHeader and do the same for ReplaceFooter

from docx.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.