SignalStore Methods code snipped has probably a flaw about platform

[markostanimirovic]

Hi @ValentinBossi,

Feel free to create a PR to fix the example. There are two options:

1. Fix that you mentioned.
2. Or:

      pipe(
        debounceTime(300),
        distinctUntilChanged(),
        tap(() => patchState(store, { isLoading: true })),
        switchMap((query) => {
          return booksService.getByQuery(query).pipe(
            tapResponse({
              next: (books) => patchState(store, { books, isLoading: false }),
              error: (err) => {
                patchState(store, { isLoading: false });
                console.error(err);
              },
            })
          );
        }),
      )

[timdeschryver]

Hi, I don't know if I understand the question.

It does not switch back to true as expected (it looks like some klicks are just swallowed. only waiting for a couple of seconds helps, until everything works again)

This is the behavior of debounceTime: "The timeout duration in milliseconds (or the time unit determined internally by the optional scheduler) for the window of time required to wait for emission silence before emitting the most recent source value."

Moving the logic in the tap to switchMap should not affect this behavior.

[ValentinBossi]

Hi @timdeschryver thanks for checking this issue!
i have made a gif which shows it better than my words:

in case A (using patchState in tap) im able to hold isLoading=false (while typing > 300ms). that should not be possible if im correct (at least i was not able to do it in case B). in case B (using patchState in switchMap) what is possible, if im correct, is to hold isLoading=true if im always in the time constraint of which is given by debounceTime(300)&delay(2000).

maybe im doing it not really the same way in both cases and everthing is ok or i misunderstand something.
anyway thanks for checking!

[ValentinBossi]

just for the record:
finalize (andcomplete) should not be used in this case, cause switchMap calls unsubscribe on the "service" which triggers finalize (and complete) in tapResponse. this sets loading to false which is not the desired behaviour.