Coder Social home page Coder Social logo

Comments (4)

markostanimirovic avatar markostanimirovic commented on June 24, 2024 1

I opened an issue in the TS repo: microsoft/TypeScript#57318

As a workaround, you can use conditional type: example

from platform.

markostanimirovic avatar markostanimirovic commented on June 24, 2024

@Raul52

export type EntityIdProps<Entity> = {
    [K in keyof Entity as K extends EntityId ? K : never]: Entity[K];
};

👆 By applying the changes that you proposed, the EntityIdProps type will always return all props because K extends EntityId will always be true (except when some key is a symbol).


The idea with:

export type EntityIdProps<Entity> = {
    [K in keyof Entity as Entity[K] extends EntityId ? K : never]: Entity[K];
};

is to exclude all properties whose values are not string | number (not keys), because they cannot be used as identifiers.


But anyway, thanks for reporting this! Let's try to find some workaround.

from platform.

Raul52 avatar Raul52 commented on June 24, 2024

@markostanimirovic I created a complete test case and you are right, my proposed solution was wrong.

test-case

Will also actively check for a solution given the intention - which is to allow keys whose values are `string | number', but not other types.

from platform.

markostanimirovic avatar markostanimirovic commented on June 24, 2024

microsoft/TypeScript#48992

from platform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.