Comments (4)
I opened an issue in the TS repo: microsoft/TypeScript#57318
As a workaround, you can use conditional type: example
from platform.
export type EntityIdProps<Entity> = {
[K in keyof Entity as K extends EntityId ? K : never]: Entity[K];
};
👆 By applying the changes that you proposed, the EntityIdProps
type will always return all props because K extends EntityId
will always be true (except when some key is a symbol).
The idea with:
export type EntityIdProps<Entity> = {
[K in keyof Entity as Entity[K] extends EntityId ? K : never]: Entity[K];
};
is to exclude all properties whose values are not string | number
(not keys), because they cannot be used as identifiers.
But anyway, thanks for reporting this! Let's try to find some workaround.
from platform.
@markostanimirovic I created a complete test case and you are right, my proposed solution was wrong.
Will also actively check for a solution given the intention - which is to allow keys whose values are `string | number', but not other types.
from platform.
from platform.
Related Issues (20)
- Simplify patchState() method for enhanced developer experience HOT 1
- provideState cannot be used in standalone components HOT 3
- @ngrx/signals: updateEntity method don't update key in entityMap HOT 9
- ngRx 17 causing breaking unit tests - multiple issues HOT 2
- minor perf improvement, signal store excludeKeys
- dynamically parametrized selectors (dynamic range of computeds) HOT 3
- docs: Reusing `extraSelectors` in the `createFeature` HOT 1
- bake in patchState immutability for simplicity HOT 8
- potential degradation of withMethods generic types inference HOT 5
- Inconsistent providing of services leads to problems with module federation HOT 1
- @ngrx/signals: `mockSignalStore` feature HOT 15
- @ngrx/component-store: Add migration schematic for `tapResponse` operator HOT 1
- @ngrx/effects: Add migration schematic for `concatLatestFrom` operator HOT 2
- Use of rxMethod in service or component without signalStore HOT 1
- untracked for all methods? HOT 4
- @ngrx/signals: ability to save entity class instance on updateEntity() HOT 1
- Expose more models to the public API: SignalStoreFeatureResult and InputSignalStore<Input>
- Using a custom generic function for defining props in createActionGroup results in weird TypeScript errors HOT 4
- Chaining custom signal store features with input declared as functions fails HOT 2
- @ngrx/effects/src/effect_creator.d.ts:12:43 - error TS2313: Type parameter 'OT' has a circular constraint. HOT 17
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from platform.