Locales Support about falso

[michaelxvoelker]

I started to work on it. Would provide a draft PR over the weekend. 😊

[NetanelBasal]

Yes, the next step should be the third option using second entry points.

[NetanelBasal]

Yes, but they will be imported from the main package

[shhdharmen]

I can check this.

[iamandrewluca]

I saw PR related to this issue. That's very cool that we can use Google Translate to translate. But in terms of library API, how this will work taking into consideration that needs to be tree shakeable? 🤔

import { locale } from '@ngneat/falso'

// Something like this?
locale('en')

or maybe we can generate per locale bundles? 🤔
and the default @ngneat/falso is English version

import { randomWord } from '@ngneat/falso/de'
randomWord()

or we can make everything that is not translateable to be imported from @ngneat/falso
and everything else that is translateble to be imported from @ngneat/falso/<locale>

I like more this third option

[NetanelBasal]

@theryansmee do you think you can handle this?

[theryansmee]

@NetanelBasal - Sorry I don't have any experience with this. It would probably be better suited for someone else.

[iamandrewluca]

What would be the approach here. Using fileReplacements or ENV properties to replace default locale e.g. en.json with de.json and do builds for each locale?

Wouldn’t it be better for functions that need locales, to group them in own folder?

packages/falso/src/lib/abbreviation/index.ts
packages/falso/src/lib/abbreviation/en.json
packages/falso/src/lib/abbreviation/de.json
packages/falso/src/lib/abbreviation/<locale>.json

[NetanelBasal]

We don't want it as a separate npm package. The goal is to import it as:

import { randName } from @ngneat/falso/locales/ru

[iamandrewluca]

We don't want it as a separate npm package. The goal is to import it as:

Exactly, but each locale subfolder will be a completely different build 🤔

[iamandrewluca]

Main folder will be something like this

And each locale subfolder, something like this 🤔

[NetanelBasal]

yes

[irg1008]

Hi I am sorry but the only random value exported from locales seems to be "randomBird". Is this right?