Add C++ compatibility about libnfc

[GoogleCodeExporter]

Can this be somehow combined with a fix for issue 14?

Original comment by fkooman%[email protected] on 3 Sep 2009 at 2:30

[GoogleCodeExporter]

Thanks for report and solution.
r90 should fix this issue, code review wanted.

Original comment by [email protected] on 3 Sep 2009 at 3:26

• Changed state: Fixed

[GoogleCodeExporter]

r97 may allow C++ compatibility in Windows (code review and bug report is 
welcome).

Original comment by [email protected] on 4 Sep 2009 at 2:08

[GoogleCodeExporter]

C++ compatibility broken in r123.

Original comment by [email protected] on 1 Oct 2009 at 8:40

• Changed state: New

[GoogleCodeExporter]

Please fix it

Original comment by emanuele.bertoldi on 2 Oct 2009 at 10:49

[GoogleCodeExporter]

Talking with Roel about this issue, we think you could try to include libnfc 
like that:
{{{
extern "C" {
#include <libnfc.h>
}
}}}
This should export libnfc functions in C++.

Original comment by [email protected] on 2 Oct 2009 at 1:07

[GoogleCodeExporter]

ok, but why this decision? 

In my opinion the "NFCAPI prefix" approach is better.

Original comment by emanuele.bertoldi on 5 Oct 2009 at 1:11

[GoogleCodeExporter]

I don't know exactly why Roël removes this but could you explain why you think 
that
"NFCAPI prefix" is a better approach ?

Original comment by [email protected] on 6 Oct 2009 at 10:12

• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Because, from a developer point of view, this makes easier to use this lib 
without
explicit declarations in the C++ project code. In my small experience, every C 
lib
I've seen use this approach.

Original comment by emanuele.bertoldi on 21 Oct 2009 at 1:55

[GoogleCodeExporter]

You are right, we may wan to to go back to the extern "C" declaration. But can 
we
avoid that is compiled into the documentation? It is rather annoying if you see 
wierd
and "unknown" API (return) types. Maybe we just should add in the top of 
libnfc.h:

#ifdef __cplusplus 
    #define NFCAPI extern "C" {
#endif // __cplusplus

and in the bottom:
#ifdef __cplusplus 
}
#endif // __cplusplus

What do you both think about this?

Original comment by [email protected] on 31 Oct 2009 at 1:19

[GoogleCodeExporter]

I agreed. This is fixed in r159.

Original comment by [email protected] on 2 Nov 2009 at 7:48

• Changed state: Fixed

[GoogleCodeExporter]

It seems to be not fixed...The problem is in "#define NCAPI ..." line. You must
remove the "define" stuff:

#ifdef __cplusplus 
extern "C" {
#endif // __cplusplus

// ...

#ifdef __cplusplus 
}
#endif // __cplusplus

Original comment by emanuele.bertoldi on 2 Dec 2009 at 8:34

[GoogleCodeExporter]

This is the very trivial patch for the current revision (r236).

Original comment by emanuele.bertoldi on 7 Dec 2009 at 2:45

Attachments:

• nfc.h.patch

[GoogleCodeExporter]

Original comment by emanuele.bertoldi on 8 Dec 2009 at 2:28

• Changed state: New
• Added labels: Priority-Medium
• Removed labels: Priority-Low

[GoogleCodeExporter]

Original comment by emanuele.bertoldi on 8 Dec 2009 at 3:10

• Changed state: Fixed