Coder Social home page Coder Social logo

Mitochondria workflow about raredisease HOT 20 CLOSED

nf-core avatar nf-core commented on June 16, 2024 1
Mitochondria workflow

from raredisease.

Comments (20)

jfy133 avatar jfy133 commented on June 16, 2024 2

I don't think we need a specific Mito dataset that can't be swapped out for another circular genome (e.g. bacteria).

That said all of the pipeline tests dataset is mammoth MiTo genomes.... But only because it was small.

Regardless I don't think we would anything special :)

Happy to give input on any discussion though

from raredisease.

maxulysse avatar maxulysse commented on June 16, 2024 1

Yeah, @GCJMackenzie has wonderfully made many modules + test data for it, so plan would be to add it there soonish
cc @FriederikeHanssen

from raredisease.

FriederikeHanssen avatar FriederikeHanssen commented on June 16, 2024 1

module for mutect2 is already in nf-core/modules https://github.com/nf-core/modules/tree/master/modules/gatk4/mutect2 It is much more comprehensive than my tiny attempt in sarek, so we will definitely use that one, just haven't gotten around to do this, but hopefully during the next couple of days there is time

from raredisease.

GCJMackenzie avatar GCJMackenzie commented on June 16, 2024 1

Might be best if I change -L chrM to a string input, that way its not hardcoded to use the 'chrM' label. This might also save some issues down the line if the pipeline tests are mammoth miTos and have a different labelling system.
The --mitochondria-mode seems to just change a few other settings to make the detection more sensitive, so if I am reading the gatk documentation correctly we might be able to just use a bacterial dataset (fingers crossed) :)
Will give it a go tomorrow.

from raredisease.

FriederikeHanssen avatar FriederikeHanssen commented on June 16, 2024 1

sounds great. and some bacterial should already be in the testdata repo 🥳

from raredisease.

Gwennid avatar Gwennid commented on June 16, 2024

The module for vep is called "ensemblvep".

from raredisease.

jemten avatar jemten commented on June 16, 2024

Nice! Looking forward to this one

from raredisease.

Gwennid avatar Gwennid commented on June 16, 2024

There is a local module for Mutect2 in Sarek (dev branch) so perhaps we can use it somehow.

from raredisease.

jemten avatar jemten commented on June 16, 2024

Yeah, let's reuse as much code as possible.

@maxulysse, any plans of taking the mutect2 module to nf-core?

from raredisease.

Gwennid avatar Gwennid commented on June 16, 2024

Thanks @FriederikeHanssen ! I had overlooked it...

from raredisease.

FriederikeHanssen avatar FriederikeHanssen commented on June 16, 2024

no worries, but that is the beauty of the modules 😍

from raredisease.

GCJMackenzie avatar GCJMackenzie commented on June 16, 2024

Hi all, the module on nf-core currently does not have a specific mitochondrial mode, but I don't think it would be too tricky to add, if you needed it in a rush a workaround currently would be to run the generate_pon mode with the additional arguments -L chrM and --mitochondria-mode.

from raredisease.

GCJMackenzie avatar GCJMackenzie commented on June 16, 2024

@FriederikeHanssen @Gwennid I have started adding in a mitochondrial mode for mutect2. I don't suppose there is any test data for mitochondria yet is there?

from raredisease.

Gwennid avatar Gwennid commented on June 16, 2024

I don't know of any.
I'd be happy to help, but I cannot promise much before mid-November unfortunately.

from raredisease.

FriederikeHanssen avatar FriederikeHanssen commented on June 16, 2024

nope, not as far as i am aware and the keys don't indicate as such yet. Maybe the eager crowd knows more? @jfy133 anything like that on your side yet? Or would it be useful for you in the future? In that case it would probably be good to collect requirements from the start

from raredisease.

GCJMackenzie avatar GCJMackenzie commented on June 16, 2024

I think the changes to the module code itself are good, could upload a PR tomorrow with them. Unfortunately the tests fail since our current test data is for chr22 and not the mitochondria. (was hoping maybe mutect2 would give us a blank vcf but no luck, mutect2 doesn't like when -L specifies a chromosome not present in the file.)

from raredisease.

GCJMackenzie avatar GCJMackenzie commented on June 16, 2024

@jfy133 I think you are right :) I'd be happy to use a dataset that isn't human. The error being thrown at me is that there isn't a chrM labelled in my test files.

from raredisease.

FriederikeHanssen avatar FriederikeHanssen commented on June 16, 2024

can we change the label in the bacteria dataset or will that cause some other unintended problem 🤔

from raredisease.

Gwennid avatar Gwennid commented on June 16, 2024

@sysbiocoder , @Lucpen and @Gwennid have discussed how to structure the mitochondria subworkflow. At the moment we are thinking of separating it in three: one part for each of the two parallel "tracks" (see here) and a main part with the three initial steps, that prepares the inputs for the two parallel tracks, calls them, and then joins the outputs and runs the end (annotation etc).

from raredisease.

ramprasadn avatar ramprasadn commented on June 16, 2024

Closing this issue since this feature is already implemented in the pipeline.

from raredisease.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.