Comments (7)
This bug is due to this line of code:
It probably needs to be changed to:
it.blocking = it.blocking.replaceAll('^NA$', '')
from differentialabundance.
The comment directly before this code block reads:
// Split the contrasts up so we can run differential analyses and
// downstream plots separately.
// Replace NA strings that might have snuck into the blocking column
Why would this code block try to replace NA sub-strings in column headers of the samplesheet.csv file? Maybe you apply it to samplesheet.csv, too?
from differentialabundance.
The issue is that the current code replaces any "NA" in the string. Mine only replaces it if it's the whole string. However, come to think of it, IDK why it's replacing it in the variable name anyway, and whether that's desired behavior
from differentialabundance.
I assume (carefully) that .splitCsv might add NAs when it finds an empty column; is that correct, @pinin4fjords?
Edit: No it doesn't, at least not in a little test I ran. Why might NAs sneak in? 🤔
from differentialabundance.
Thanks for the bug report!
This was definitely done in response to a bug, possibly people using NA in the input contrasts files to indicate missing values. So I don't want to remove this entirely.
@BEFH - could you PR your regex fix please, since it's so concise? Please add a changelog entry in the same style as the others there when you do so.
We should also document the special meaning of 'NA'.
from differentialabundance.
Hey, checking for and dealing with NA entries in contrasts.csv seems reasonable. But, replacing any pattern match of 'NA' with the empty string will destroy meaningful entries like 'RNA_CONCENTRATION' or 'ANALYSIS_OUTCOME' and so on. Would it be possible to replace 'NA' with the empty string only if the complete entry is 'NA' (in perl ^NA$) but otherwise don't replace NAs?
from differentialabundance.
Yes, that's the fix proposed by @BEFH
from differentialabundance.
Related Issues (20)
- Remove parameter --gsea_run HOT 1
- URGENT: pin nf-validation version HOT 2
- Dev version: On parameters website list parameter gene_sets_files in section GSEA HOT 1
- Continuous covariates HOT 6
- Please pin the version of the nf-validation plugin! HOT 1
- Error with samplesheet.csv with two column headers that have prefix in common HOT 8
- release differentialabundance HOT 1
- Process `NFCORE_DIFFERENTIALABUNDANCE:DIFFERENTIALABUNDANCE:GTF_TO_TABLE (gencode)` terminated with an error exit status (125) HOT 4
- Error in TABULAR_TO_GSEA_CHIP HOT 1
- GSEA html reports have broken links to png and TSV files HOT 1
- Failed to publish file => double forward slashes
- Auto-format sample names HOT 2
- PosixFileAttributeView
- Missing colour and hover labels in interactive report volcano plot HOT 4
- Normalized/Raw data mishap on the report HOT 1
- Provide a parameter to disable rmarkdown report creation in the differential abundance pipeline HOT 2
- Requests: Enhancements to DESeq2 csv outputs and PDF outputs
- For spike-in analysis, remove control features from outputs
- How to use `--transcript_length_matrix` with nf-core/rnaseq `--aligner star_rsem` output? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from differentialabundance.