[Bug]: Running user:info on user who hasn't logged in creates a folder about server

[Pytal]

cc @icewind1991

[joshtrichards]

The data/user directory gets created at account creation time. Behavior looks the same at least back as far back as I checked (v27)...

I presume you mean the files folder underneath? I'm not able to reproduce the files folder getting created merely by running the occ user:info newuser command.

[Pytal]

The data/user directory gets created at account creation time. Behavior looks the same at least back as far back as I checked (v27)...

Yes, when creating in the web UI the folder is created but not through occ.

The steps to reproduce would be:

1. Create a user occ user:add --generate-password -- bob (Do not try to access any user info through the web UI or otherwise)
2. Run user:info <user>

[Pytal]

Behaviour seems a bit strange as a data access should not create anything but since this has behaved this way for a long time maybe not worth changing @icewind1991?

[joshtrichards]

Looks like the getStorageInfo() used by user:info calls setupFS() regardless of login status:

server/core/Command/User/Info.php

Lines 77 to 94 in 2b2a866

	'storage' => $this->getStorageInfo($user),
	'last_seen' => date(\DateTimeInterface::ATOM, $user->getLastLogin()), // ISO-8601
	'user_directory' => $user->getHome(),
	'backend' => $user->getBackendClassName()
	];
	$this->writeArrayInOutputFormat($input, $output, $data);
	return 0;
	}
	/**
	* @param IUser $user
	* @return array
	*/
	protected function getStorageInfo(IUser $user): array {
	\OC_Util::tearDownFS();
	\OC_Util::setupFS($user->getUID());
	try {
	$storage = \OC_Helper::getStorageInfo('/');

Maybe?

diff --git a/core/Command/User/Info.php b/core/Command/User/Info.php
index a8fb62099e2..75060ec8e2e 100644
--- a/core/Command/User/Info.php
+++ b/core/Command/User/Info.php
@@ -74,7 +74,7 @@ class Info extends Base {
                        'enabled' => $user->isEnabled(),
                        'groups' => $groups,
                        'quota' => $user->getQuota(),
-                       'storage' => $this->getStorageInfo($user),
+                       'storage' => $user->getLastLogin() ? $this->getStorageInfo($user) : [],
                        'last_seen' => date(\DateTimeInterface::ATOM, $user->getLastLogin()), // ISO-8601
                        'user_directory' => $user->getHome(),
                        'backend' => $user->getBackendClassName()

Yes, when creating in the web UI the folder is created but not through occ.

Guess those should be made consistent too. :-)

[Pytal]

Closing as discussed with @icewind1991