[Bug]: Search in the"disabled users" section does not work about server

[come-nc]

Version 27 was using this endpoint: /ocs/v2.php/cloud/users/details?offset=0&limit=25&search=<search>. Maybe it can help to reenable it?

Reenable it where?
It is still used for enabled users I think. The problem is disabled users are now fetched through a dedicated endpoint and search was not baked in.

[sorbaugh]

Looping in @Altahrim and @Fenn-CS as this seems related to Unified Search

[joshtrichards]

Reminds me of #43658 a little.

[Pytal]

Had a look and filtering in the disabled users section doesn't work like it does in "Active users" because we use an optimized endpoint for querying disabled users which unlike the general users endpoint does not accept a search query

We would need to accept a search query here

server/lib/public/User/Backend/IProvideEnabledStateBackend.php

Line 55 in 880f33e

public function getDisabledUserList(?int $limit = null, int $offset = 0): array;

and update the LDAP implementation cc @come-nc

[come-nc]

It’s a bit complicated to support search in disabled users. We’d need to add a search parameter to implementations of IProvideEnabledStateBackend, which means adding yet another interface as this one is out already.
Or we filter in user management but that will be slow and resource expensive.

[Pytal]

It’s a bit complicated to support search in disabled users. We’d need to add a search parameter to implementations of IProvideEnabledStateBackend, which means adding yet another interface as this one is out already. Or we filter in user management but that will be slow and resource expensive.

I'd say the best option would be adding the search param as since user listing is paginated then filtering on frontend only would show no existing user if they have not already been fetched in the batch of paged users unlike in "Active users"

[Altahrim]

Version 27 was using this endpoint: /ocs/v2.php/cloud/users/details?offset=0&limit=25&search=<search>. Maybe it can help to reenable it?