Backup job not creating backups about bookmarks

[cpence]

Yes! That fixed backup generation on my end, at least.

[github-actions]

Hello 👋

Thank you for taking the time to open this issue with the bookmarks app. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and have been maintaining this software the last few years. I currently work for Nextcloud but maintain this app
in my free time, because it is not an official Nextcloud product. My day job at Nextcloud is pretty awesome but sadly leaves me with
less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself. (Also see our Code of Conduct. Really.)

I look forward to working with you on this issue
Cheers 💙

[marcelklehr]

Hey @cpence
Could you post the database entry of the job here? Also, did it work for you before, if so, what changed?

[marcelklehr]

Also, do you have backups enabled for the current user in the bookmarks settings?

[cpence]

I do have backups enabled for the user in the bookmarks settings, with the correct path set into my NC directory (chosen w/ the file picker, just to be sure). Database entries for all the jobs for the bookmarks app are:

+--------+-------------------------------------------------------------------+-------------------------------------------------------------------
-------------------------------------------------------------------------------------------------------------------------------------------------
----------------------------------------------------------------------------+------------+--------------+-------------+--------------------+-----
-----------------------------+----------------+
| id     | class                                                             | argument                                                          
                                                                                                                                                 
                                                                            | last_run   | last_checked | reserved_at | execution_duration | argument_hash                    | time_sensitive |
+--------+-------------------------------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+------------+--------------+-------------+--------------------+----------------------------------+----------------+
259cc0c1dae299a7866489dff0bd |              1 |
|    203 | OCA\Bookmarks\BackgroundJobs\CrawlJob                             | null                                                              
                                                                                                                                                 
                                                                            | 1716108601 |   1716108901 |           0 |                  0 | 37a6
259cc0c1dae299a7866489dff0bd |              1 |
|    204 | OCA\Bookmarks\BackgroundJobs\FileCacheGCJob                       | null                                                              
                                                                                                                                                 
                                                                            | 1716108601 |   1716108901 |           0 |                  0 | 37a6
259cc0c1dae299a7866489dff0bd |              1 |
|    205 | OCA\Bookmarks\BackgroundJobs\BackupJob                            | null                                                              
                                                                                                                                                 
                                                                            | 1716097209 |   1716098101 |           0 |                  0 | 37a6

Looks like the BackupJob last ran 3h ago, and I still have no files in my backups folder. Backups haven't worked since I set this server up, no, so there's not been a change in behavior. Thanks for your help!

[marcelklehr]

Did you first set the server up with NC 29?

[marcelklehr]

Are you up for a little experiment?

Can you change this line in your installation: https://github.com/nextcloud/bookmarks/blob/master/lib/BackgroundJobs/BackupJob.php#L48

to the following:

$userIds = $this->config->getUsersForUserValue('bookmarks', 'backup.enabled', 'true');

[marcelklehr]

You may have to wait until your maintenance window begins to see whether this fixes things.

[cpence]

I did set it up with NC29 from the very beginning. I'll go make that change now and report back tomorrow.

[marcelklehr]

Awesome, see you tomorrow :)