Build succeeds even if git push fails about gradle-release-plugin

[netzwerg]

Thanks for your report and the hint. I will look into it asap.

[jthurne]

Your right! Sorry for the false alarm.

[jthurne]

I think changing ReleaseTask Line 76 to this should do the trick:

}.assertNormalExitValue()

See org.gradle.api.Project:exec and ExecResult

[netzwerg]

Fixed in 1.2.1 (available on Bintray and Gradle plugin central).

[jthurne]

@netzwerg Great! That was impressively fast!

Unfortunately, I just realized something about what I suggested and what you implemented: if the git command fails, then no output from the command will be logged, which would make it pretty hard to figure out why it failed.

Should be another pretty easy fix:

  def result = project.exec { //stuff }
  // print out the output (if any)
  result.assertNormalExitValue()

[netzwerg]

I tested it with a repo for which I removed all remotes but still have a release { push = true } configuration. The underlying git error is then written to the console:

:release
fatal: 'origin' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
:release FAILED

It's not pretty, but should be sufficient to figure out why the build failed.

But you are correct, the output should also be logged – thanks for the pointer!

[netzwerg]

Actually I do get log entries:

20:59:16.934 [ERROR] [system.err] fatal: 'origin' does not appear to be a git repository
20:59:16.935 [ERROR] [system.err] fatal: Could not read from remote repository.
20:59:16.936 [ERROR] [system.err]
20:59:16.936 [ERROR] [system.err] Please make sure you have the correct access rights
20:59:16.936 [ERROR] [system.err] and the repository exists.

no output from the command will be logged

Do you really see nothing at all?