vpp bridge created with serious delay for vlan connection about cmd-forwarder-vpp

[johlj]

Hi,

ah it got in, great :)
We'll check but think it should be fine

Br,
Johan

[zolug]

forwarder-vpp-ddqqp.5ed4cbb45dd25ee.log

[denis-tingaikin]

@edwarnicke Is this a release blocker?

[zolug]

According to the logs during the initial connection request the "official" forwarder-vpp version skips the bridge setup part after the tap interface is configured:

5ed4cbb:

Dec 15 14:51:22.276ESC[37m [DEBU] [id:3621c89d-8eb6-4a58-b15d-5556703fb51f] [HostIfName:ext-1] [HostNamespace:/proc/1/fd/19] [TapFlags:TapFlags(0)] [duration:26.09085ms] [swIfIndex:3] [type:networkServic
e] [vppapi:TapCreateV2] ESC[0m(29.2)                               completed
Dec 15 14:51:22.276ESC[37m [DEBU] [id:3621c89d-8eb6-4a58-b15d-5556703fb51f] [duration:115.967µs] [mode:RX_MODE_API_ADAPTIVE] [swIfIndex:3] [type:networkService] [vppapi:SwInterfaceSetRxMode] ESC[0m(29.3)
                               completed
Dec 15 14:51:22.276ESC[37m [DEBU] [id:3621c89d-8eb6-4a58-b15d-5556703fb51f] [duration:57.061µs] [link.Name:ext-1] [netlink:LinkByName] [type:networkService] ESC[0m(29.4)                               com
pleted
Dec 15 14:51:22.276ESC[37m [DEBU] [id:3621c89d-8eb6-4a58-b15d-5556703fb51f] [alias:server-2f9a1e8a-2c6b-494f-b0c8-aaf80ce91200] [duration:27.377µs] [link.Name:ext-1] [netlink:LinkSetAlias] [type:networkS
ervice] ESC[0m(29.5)                               completed
Dec 15 14:51:22.276ESC[37m [DEBU] [id:3621c89d-8eb6-4a58-b15d-5556703fb51f] [duration:7.486µs] [link.Name:ext-1] [netlink:LinkSetUp] [type:networkService] ESC[0m(29.6)                               compl
eted
Dec 15 14:51:22.277ESC[37m [DEBU] [id:3621c89d-8eb6-4a58-b15d-5556703fb51f] [duration:55.379µs] [swIfIndex:3] [tag:3621c89d-8eb6-4a58-b15d-5556703fb51f] [type:networkService] [vppapi:SwInterfaceTagAddDel
] ESC[0m(26.1)                            completed
Dec 15 14:51:22.277ESC[37m [DEBU] [id:3621c89d-8eb6-4a58-b15d-5556703fb51f] [Addr:169.254.100.1/24] [duration:36.657µs] [link.Name:ext-1] [netlink:AddrAdd] [type:networkService] ESC[0m(24.1)                          completed
Dec 15 14:51:22.277ESC[37m [DEBU] [id:3621c89d-8eb6-4a58-b15d-5556703fb51f] [Addr:100:100::1/64] [duration:35.531µs] [link.Name:ext-1] [netlink:AddrAdd] [type:networkService] ESC[0m(24.2)                          completed
Dec 15 14:51:22.277ESC[37m [DEBU] [id:3621c89d-8eb6-4a58-b15d-5556703fb51f] [AddrUpdate.LinkAddress:{169.254.100.1 ffffff00}] [duration:11.052µs] [link.Name:ext-1] [type:networkService] ESC[0m(24.3)                          complete
Dec 15 14:51:22.277ESC[37m [DEBU] [id:3621c89d-8eb6-4a58-b15d-5556703fb51f] [AddrUpdate.LinkAddress:{100:100::1 ffffffffffffffff0000000000000000}] [duration:88.521µs] [link.Name:ext-1] [type:networkService] ESC[0m(24.4)                          complete
Dec 15 14:51:22.278ESC[36m [INFO] [id:3621c89d-8eb6-4a58-b15d-5556703fb51f] [VLAN-ID:100] [type:networkService] ESC[0m(16.1)                  bridge is used instead of xconnect

registry.nordix.org/cloud-native/nsm/cmd-forwarder-vpp:with-bd-wout-mac:

Dec 15 15:23:51.092ESC[37m [DEBU] [id:1245dadf-2476-486c-9550-3ad8520aad3a] [HostIfName:ext-1] [HostNamespace:/proc/1/fd/19] [TapFlags:TapFlags(0)] [duration:42.254814ms] [swIfIndex:3] [type:networkServi
ce] [vppapi:TapCreateV2] ESC[0m(29.2)                               completed
Dec 15 15:23:51.092ESC[37m [DEBU] [id:1245dadf-2476-486c-9550-3ad8520aad3a] [duration:111.114µs] [mode:RX_MODE_API_ADAPTIVE] [swIfIndex:3] [type:networkService] [vppapi:SwInterfaceSetRxMode] ESC[0m(29.3)
                               completed
Dec 15 15:23:51.093ESC[37m [DEBU] [id:1245dadf-2476-486c-9550-3ad8520aad3a] [duration:44.337µs] [link.Name:ext-1] [netlink:LinkByName] [type:networkService] ESC[0m(29.4)                               com
pleted
Dec 15 15:23:51.093ESC[37m [DEBU] [id:1245dadf-2476-486c-9550-3ad8520aad3a] [alias:server-5de74de3-8008-4935-a417-3e58d7e30532] [duration:35.466µs] [link.Name:ext-1] [netlink:LinkSetAlias] [type:networkS
ervice] ESC[0m(29.5)                               completed
Dec 15 15:23:51.093ESC[37m [DEBU] [id:1245dadf-2476-486c-9550-3ad8520aad3a] [duration:7.448µs] [link.Name:ext-1] [netlink:LinkSetUp] [type:networkService] ESC[0m(29.6)                               compl
eted
Dec 15 15:23:51.093ESC[37m [DEBU] [id:1245dadf-2476-486c-9550-3ad8520aad3a] [duration:51.773µs] [swIfIndex:3] [tag:1245dadf-2476-486c-9550-3ad8520aad3a] [type:networkService] [vppapi:SwInterfaceTagAddDel
] ESC[0m(26.1)                            completed
Dec 15 15:23:51.093ESC[37m [DEBU] [id:1245dadf-2476-486c-9550-3ad8520aad3a] [Addr:169.254.100.1/24] [duration:39.922µs] [link.Name:ext-1] [netlink:AddrAdd] [type:networkService] ESC[0m(24.1)                          completed
Dec 15 15:23:51.093ESC[37m [DEBU] [id:1245dadf-2476-486c-9550-3ad8520aad3a] [Addr:100:100::1/64] [duration:42.47µs] [link.Name:ext-1] [netlink:AddrAdd] [type:networkService] ESC[0m(24.2)                          completed
Dec 15 15:23:51.093ESC[37m [DEBU] [id:1245dadf-2476-486c-9550-3ad8520aad3a] [AddrUpdate.LinkAddress:{169.254.100.1 ffffff00}] [duration:8.649µs] [link.Name:ext-1] [type:networkService] ESC[0m(24.3)                          complete
Dec 15 15:23:51.094ESC[37m [DEBU] [id:1245dadf-2476-486c-9550-3ad8520aad3a] [AddrUpdate.LinkAddress:{100:100::1 ffffffffffffffff0000000000000000}] [duration:81.947µs] [link.Name:ext-1] [type:networkService] ESC[0m(24.4)                          complete
Dec 15 15:23:51.106ESC[36m [INFO] [id:1245dadf-2476-486c-9550-3ad8520aad3a] [bridgeID:7271263] [duration:11.895076ms] [isAdd:true] [type:networkService] [vppapi:BridgeDomainAddDelV2] ESC[0m(18.1)                    completed
Dec 15 15:23:51.106ESC[36m [INFO] [id:1245dadf-2476-486c-9550-3ad8520aad3a] [bridgeID:7271263] [duration:120.082µs] [isAdd:true] [shg:1] [swIfIndex:3] [type:networkService] [vppapi:SwInterfaceSetL2Bridge] ESC[0m(18.2)                    completed
Dec 15 15:23:51.106ESC[36m [INFO] [id:1245dadf-2476-486c-9550-3ad8520aad3a] [bridgeID:7271263] [duration:146.24µs] [isAdd:true] [shg:0] [swIfIndex:2] [type:networkService] [vppapi:SwInterfaceSetL2Bridge] ESC[0m(18.3)                    completed
Dec 15 15:23:51.107ESC[36m [INFO] [id:1245dadf-2476-486c-9550-3ad8520aad3a] [VLAN-ID:100] [type:networkService] ESC[0m(16.1)                  bridge is used instead of xconnect

[zolug]

I guess the problem is that in l2bridgedomain request during the initial request the vlan id can not be loaded from the metadata yet as no response was received at that stage from the NSE. IMHO checking for vlan would make sense after next.Server.

The following changes fixed the problem for me:

diff --git a/pkg/networkservice/xconnect/l2bridgedomain/server.go b/pkg/networkservice/xconnect/l2bridgedomain/server.go
index 8267936..0a79f2a 100644
--- a/pkg/networkservice/xconnect/l2bridgedomain/server.go
+++ b/pkg/networkservice/xconnect/l2bridgedomain/server.go
@@ -46,9 +46,7 @@ func NewServer(vppConn api.Connection) networkservice.NetworkServiceServer {
 }
 
 func (v *l2BridgeDomainServer) Request(ctx context.Context, request *networkservice.NetworkServiceRequest) (*networkservice.Connection, error) {
-       vlanID, ok := vlan.Load(ctx, true)
-       // return if the belonging remote mechanism not vlan mechanism
-       if !ok || request.GetConnection().GetPayload() != payload.Ethernet {
+       if request.GetConnection().GetPayload() != payload.Ethernet {
                return next.Server(ctx).Request(ctx, request)
        }
 
@@ -59,6 +57,12 @@ func (v *l2BridgeDomainServer) Request(ctx context.Context, request *networkserv
                return nil, err
        }
 
+       // return if the belonging remote mechanism not vlan mechanism
+       vlanID, ok := vlan.Load(ctx, true)
+       if !ok {
+               return conn, err
+       }
+
        if err := addBridgeDomain(ctx, v.vppConn, &v.b, vlanID); err != nil {
                closeCtx, cancelClose := postponeCtxFunc()
                defer cancelClose()

[johlj]

@edwarnicke @denis-tingaikin

Hi,

do you think it would be possible to get this into NSM 1.7? Not sure if we will be able to use the release without this fix

Br,
Johan

[denis-tingaikin]

@johlj Seems like it is fixed by #781

The fix #781 is included in v1.7.0

Could you please check this on
https://github.com/networkservicemesh/deployments-k8s/tree/release/v1.7.0?

[denis-tingaikin]

@johlj Do you have any updates?

[johlj]

Hi,

yes this issue is resolved

Br,
Johan

[denis-tingaikin]

Nice!

Feel free to open new tickets for problems that you see 😉