3D point serialization exception about nettopologysuite.io.geojson

[HarelM]

@airbreather @FObermaier anyone? Seems like a straight forward case, I'm not sure what I'm missing... :-(

[HarelM]

Ok, Found the bug and found the solution.
It's a one line change:
Missing the following line in CoordinateConverter.CanConvert:
typeof(Coordinate).IsAssignableFrom(objectType) ||
So the function should look as follows:

        public override bool CanConvert(Type objectType)
        {
            return objectType == typeof(Coordinate) ||
                   objectType == typeof(Coordinate[]) ||
                   objectType == typeof(List<Coordinate[]>) ||
                   objectType == typeof(List<List<Coordinate[]>>) ||
                   typeof(Coordinate).IsAssignableFrom(objectType) ||
                   typeof(IEnumerable<Coordinate>).IsAssignableFrom(objectType) ||
                   typeof(IEnumerable<IEnumerable<Coordinate>>).IsAssignableFrom(objectType) ||
                   typeof(IEnumerable<IEnumerable<IEnumerable<Coordinate>>>).IsAssignableFrom(objectType);
        }

Let me know if you need a PR for this.
I'm in the middle of the migration and it would help me a lot if you can add this and create a new Nuget Package.

Relevant test:

        [Test, GeoJsonIssueNumber(41)]
        public void Test3DPointSerialization()
        {
            var featureCollection = new FeatureCollection { new Feature(new Point(1, 2, 3), new AttributesTable()) };
            var writer = new StringWriter();
            var jsonWriter = new JsonTextWriter(writer);
            var serializer = GeoJsonSerializer.Create(new GeometryFactory(), 3);
            serializer.Serialize(jsonWriter, featureCollection);
            string json = writer.ToString();
            Assert.That(json, Is.EqualTo("{\"type\":\"FeatureCollection\",\"features\":[{\"type\":\"Feature\",\"geometry\":{\"type\":\"Point\",\"coordinates\":[1.0,2.0,3.0]},\"properties\":{}}]}"));
        }

[HarelM]

I have created the relevant pull request (#43), easier than writing what you should change :-)
Can this please please be merged and with a new NuGet package release? I really need this...

[HarelM]

I have found a workaround to use the following patch until a new version will be released.

public class CoordinateConverterPatch : CoordinateConverter
    {
        public CoordinateConverterPatch() : base() { }
        public CoordinateConverterPatch(PrecisionModel precisionModel, int dimension) : base(precisionModel, dimension) { }

        public override bool CanConvert(Type objectType)
        {
            return base.CanConvert(objectType) || typeof(CoordinateZ) == objectType;
        }
    }

Which can be added to the JsonSerializer converters.
Keep me posted on the new NuGet.

[airbreather]

@HarelM thanks for reporting this and for doing all the work to find a fix for it. Note that you do need to use one of the GeoJsonSerializer.Create overloads that accepts the dimension parameter, since the default dimension is 2.

2.0.1 is now available on NuGet with this fix.

[HarelM]

Glad I could help, you guys are doing a great job!