Coder Social home page Coder Social logo

Comments (4)

craigsansam avatar craigsansam commented on May 27, 2024 2

I always prefer to use the Request classes to validate and authorise requests before the hit the controller.

IMO leaves less room for accidental changes which cause operations to happen before the request has been validated/authorised.

from code-standards.

Juddling avatar Juddling commented on May 27, 2024

I think we're all agreed on just not using Validator::make() unless absolutely necessary, so lets get that written down.

+1 for request classes, here's a good example which encapsulates validation, authorization + determining things about the request:

https://github.com/netsells/leap-web/blob/5cd876862658974d7763f9db9a04f3a7c55ca159/app/Http/Requests/CheckoutWebhookEventRequest.php#L21

from code-standards.

spamoom avatar spamoom commented on May 27, 2024

I think ValidatesRequests are appropriate in the right place (when it's a one off and not huge). As soon as we see repetition, request classes are a must

from code-standards.

craigsansam avatar craigsansam commented on May 27, 2024

I am going to close this RFC on Friday 22nd March and add the outcomes to the coding standards.

from code-standards.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.