Coder Social home page Coder Social logo

Comments (7)

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
Good find! I will take a look at this over the weekend!

Original comment by [email protected] on 14 Nov 2011 at 3:11

  • Changed state: Accepted

from unitt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
Sorry for the delay, the holidays are playing havoc with my schedule.

Original comment by [email protected] on 2 Dec 2011 at 1:21

  • Changed state: Fixed

from unitt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
Thanks, no worries :) 

I just took a look at your changes, and looks like you may have missed one in 
WebsocketConnection.java, line 709-731:

Currently the code looks like:
  if ( !isClosing() || aFragment.getOpCode() == MessageOpCode.CLOSE )
  {
     ...
  }
  else if ( aFragment.getOpCode() == MessageOpCode.CLOSE )
  {
     ...
  }

The if statement (on ln:709) will need to be changed to: 
  if ( !isClosing() ) 
otherwise the else if statement won't ever get called.

Thanks again.

Original comment by [email protected] on 2 Dec 2011 at 1:44

from unitt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
*Smacks Forehead* OOPS! Good catch!

Original comment by [email protected] on 6 Dec 2011 at 4:03

  • Changed state: Started

from unitt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
No worries :)

Original comment by [email protected] on 7 Dec 2011 at 2:21

from unitt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
Fixed and checked into trunk.

Original comment by [email protected] on 30 Jan 2012 at 10:11

  • Changed state: Fixed

from unitt.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024

Original comment by [email protected] on 31 Jan 2012 at 6:32

  • Changed state: Verified

from unitt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.