Coder Social home page Coder Social logo

Comments (5)

andrewachen avatar andrewachen commented on August 20, 2024

Context -- we renew at 14 days and alert at 10.

from lemur.

kevgliss avatar kevgliss commented on August 20, 2024

@andrewachen what granularity were you thinking? Is specifying an arbitrary number of days before notification enough? Would a numeric and a unit useful? (1d, 1w, 1m, 1yr)

from lemur.

andrewachen avatar andrewachen commented on August 20, 2024

Yes, numeric and a unit would be useful. For my use case, I'd be interested in alerting at 7d and 3d.

We also need the ability to acknowledge/mute an alert. For example, when we retire a site, I want to be able to manually squelch notifications for its certs.

from lemur.

kevgliss avatar kevgliss commented on August 20, 2024

Okay, this will most likely change the /certificate api adding a new optional value of 'notifications'. This would be a list of notifications that are associated with the newly created certificate. These notifications would be defined before hand and could be general or team specific. Think - my_team_notification_14_days, with a few recipients of the notification.

Certificates already have an 'active' flag, when marked as 'inactive' this will mute all associated notifications for that particular certificate.

Would this API addition warrant an API increment? Since it's optional I would think that this could be added without breaking any existing code.

I am hoping to have something for this this week.

from lemur.

andrewachen avatar andrewachen commented on August 20, 2024

I say it's not necessary to increment the version if it's a new optional field (as opposed to changing an existing field or making it required). My general rule of thumb is if existing code in the wild will continue to work after my API change, then no need to rev the api.

from lemur.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.