Comments (11)
We did reedit our tech blog to acknowledge this fact. We still keep the history of commits. We retain all of Twitter's copyrights on all the files that we used as well as other copyrights. We modified the content in a way that best fits us in accordance to licenses.
from dynomite.
@timiblossom Is there a particular problem with putting that copyright notice in the README, given that you already acknowledged it in the tech blog? It would literally be a one-line addition.
from dynomite.
Update: a few minutes after Manju twitted (without complaining) that it's a fork, the Dynomite project authors immediately documented it in the FAQ section of the Wiki: https://github.com/Netflix/dynomite/wiki/FAQ.
EDIT: Btw note that since there is apparently not a License problem at all, since copyright is retained where needed and so forth, there is not a problem. Moreover, while it's nice to acknowledge that a given project is a fork, there are people out there (for example me) that write open source in given licenses exactly in order to allow the code to be reused, with cut&paste, and search&replace and whatever is needed, as soon as the derivative work is ok with respect of the original license.
from dynomite.
We already put that in the NOTICE file a while ago.
https://github.com/Netflix/dynomite/blob/master/NOTICE
from dynomite.
Thanks for the feedback. We actually planed to reach out to all you guys for feedback but apparently, we did not do it soon enough and did not have enough time. To close the loop, Twemproxy is mentioned on our wiki, tech blog, and all copyrights are retained in all files and the NOTICE.
from dynomite.
@timiblossom thank you. I'm very exciting about Dynomite, given that Redis Cluster is a master-slave system to have a (semantically very far away) Amazon Dynamo-alike layer is great, so I look forward to your project with great interest. Also it's C so I also hope to find the time to play with it, check the source code, and time permitting, contribute if I can.
from dynomite.
@antirez please feel free to spam us anytime. Looking forward to your feedback, ideas and contributions if you have the time.
Btw, I did borrow/copy, or whatever term that is, 2 of your files :). I hope you don't mind this late notice.
Redis is an awesome software and I think we, Dynomite team, are lucky with the fact that Redis exists.
from dynomite.
I'm really happy for you to close this if you don't think it's important; it's just a suggestion that folks who read the blog post (prior to this morning's update) and README might assume that this is a de novo Netflix project.
from dynomite.
@timiblossom thanks for the kind words! No prob at all with copying my files :-) It's the whole point.
@aphyr I think the suggestion was accepted, so it's closing-after-acting IMHO, not ignoring. The original blog post was updated, and the FAQ that is going to be read by most people that dig a bit more into the project is going to clearly disclose that originally Twemproxy was forked. About the README update, that's author's pick.
from dynomite.
@aphyr please correct me if I am wrong, but I thought NOTICE file is where we put the references and copyrights. README is the document which contains what a new user should know to get started.
If this tradition is broken and twemproxy is ok to add the acknowledgement about using FreeBSD code as twemproxy's foundation code block as well as others, we will immediately do the same.
from dynomite.
In my experience, including a short copyright section in the README is typical, NOTICE covers in-tree dependencies, and LICENSE handles the top-level project license fine print. That's what Twemproxy and most Clojure/Ruby projects seem to do, but I dunno, maybe conventions are different in the C world! Not an expert here. :)
from dynomite.
Related Issues (20)
- proxy_accept:173 accept on PROXY 8 failed: Too many open file
- TEST: Redis Commands Supported HOT 1
- Dynomite logs missing HOT 2
- Make error in Debian 11: multiple definition of C2G_OutQ HOT 1
- unsupported command 'SELECT' HOT 3
- Incorrect Privilege Assignment
- brew install dynomite
- Replication is not working from appication/client side HOT 1
- Build breaks on armv6, armv7
- Warning messages when building from source
- AUTH command not supported HOT 1
- Dynomite POC question
- ERR Storage: Datastore refused connection HOT 1
- DEL/HDEL commands return (nil).
- error: incompatible pointer to integer conversion initializing 'int' with an expression of type 'void *'
- question about config dynomite described in wiki HOT 1
- Har du opp
- dynomite tokens
- SADD inconsistency HOT 1
- Dynomite / Redis Metrics
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dynomite.