Comments (27)
I'd need to see a sample. I don't get these in my own tests.
from curator.
Actually - I've started seeing them now myself. I'll see what I can do.
from curator.
Great :) maybe it's something in the new ZK?
from curator.
@akiani Thank you so much for filing this bug and, FWIW, I run into this very frequently too. I have been playing with Java7 on Mac OS X for a few days and my local tests kept on failing without anything obvious in my logs. For some reason, this bug doesn't trigger with Java 6. Now I finally know why: SyncRequestProcessor calls System.exit().
from curator.
@ntolia That's exactly the configuration that I'm using as well. Sorry I should have pointed that out...
from curator.
Actually, let me correct that, I do have Java 1.6 on my Lion:
$ java -version
java version "1.6.0_26"
Java(TM) SE Runtime Environment (build 1.6.0_26-b03-383-11A511)
Java HotSpot(TM) 64-Bit Server VM (build 20.1-b02-383, mixed mode)
from curator.
@Randgalt Is there any update on this bug? If you tell me where to go look, I would be happy to submit a patch.
from curator.
I haven't had a chance. However, my suspicion is that the problem is somewhere in the shutdown code of TestingServer and/or TestingCluster. Those classes are pretty hacked up.
from curator.
I just pushed a change to TestingServer and TestingCluster that should make this issue better. (see issue 46). Please re-try with these changes.
from curator.
Unfortunately, I still get the same failure as earlier with 1.1.5-SNAPSHOT. However, if I disable tests that use TestingServer, things work fine.
from curator.
Thanks Jordan, but I wasn't even using TestingCluster :D I was using TestingServer. I'm very surprised that fixing TestingCluster fixed my test for you... It's still failing for me with the same error.
from curator.
Seems like you forgot to git add TestingServer?
from curator.
Unfortunately, I still get the same failure as earlier with 1.1.5-SNAPSHOT. However, if I disable tests that use TestingServer, things work fine.
I didn't build new JARs. You'd have to take it from source.
from curator.
It's here: c50087d
from curator.
I didn't build new JARs. You'd have to take it from source.
I should have been clearer. I cloned master, built, installed (it showed up as 1.1.5-SNAPSHOT locally), and then tested. Things still failed.
from curator.
OK - can you put together a sample that fails? Or - are you referring to some of my tests? I realize a few tests are failing.
from curator.
Trying to create a simple test but I need to remove a bunch of internal code to get at the simplest possible repro. This is proving to be harder than expected but I should hopefully be able to have something soon. In the meantime, with master, I do get this stacktrace via a debugger but then again, that is nothing new.
Breakpoint hit: "thread=SyncThread:0", java.lang.System.exit(), line=960 bci=0
SyncThread:0[1] where
[1] java.lang.System.exit (System.java:960)
[2] org.apache.zookeeper.server.SyncRequestProcessor.run (SyncRequestProcessor.java:153)
However, one of the other threads was captured in this state:
.... (whole bunch of logback stack traces)
[23] org.apache.zookeeper.server.PrepRequestProcessor.shutdown (PrepRequestProcessor.java:733)
[24] org.apache.zookeeper.server.ZooKeeperServer.shutdown (ZooKeeperServer.java:439)
[25] com.netflix.curator.test.TestingServer.stop (TestingServer.java:152)
[26] com.netflix.curator.test.TestingServer.close (TestingServer.java:170)
Stack traces for all threads are available if it would be helpful.
Also, I don't know if it makes a difference but sometimes, when I call CuratorFramework.close() on a client that had been connected to a TestServer that has been close()d, I sometimes get a stack trace along the lines of:
Error while calling watcher
java.lang.IllegalStateException: null
at com.google.common.base.Preconditions.checkState(Preconditions.java:129) ~[guava-11.0.2.jar:na]
at com.netflix.curator.framework.state.ConnectionStateManager.addStateChange(ConnectionStateManager.java:130) ~[curator-framework-1.1.5-SNAPSHOT.jar:na]
...
from curator.
Just wanted to provide an update on this bug report. I still get the failure but I am having trouble creating a standalone test. My test does the same thing our internal code does but things work in the standalone unit test. Points to timing issues but I have nothing further than that right now. I am going to keep on digging though.
I also wonder if this is related to #47.
from curator.
I just pushed a total rewrite of TestingServer and TestingCluster based on work by Jérémie BORDIER (ahfeel). Let me know if it behaves any better.
from curator.
This is a good news/bad news story.
Good news: I no longer get a System.exit(). I had retested a couple of days ago with your zkDb.commit() patch and I was still hitting the System.exit() failure case.
Bad news: My TestingServer-based tests now hang but I need to figure out if that is just because of some thread that isn't cleaning up after itself, an internal problem that could be my fault, or something else with the TestingServer code (TestingCluster is not used in this particular suite of tests). I am going to spend some time this week looking into the hang and will let you know if I can narrow the problem down.
from curator.
:(
from curator.
I am not sure if there are timing issues there but, on a second mvn test run, TestingServer-based tests didn't hang but a few did fail (that do not fail with Java6 + Curator 1.1.5). Will keep on digging into this but am swamped with a couple of other things.
from curator.
OK - I just pushed a new version of TestingCluster that resurrects so really ugly bytecode manipulation that I didn't think was still needed. Deep inside of ZooKeeper you can get an Assertion that screws things up. With this change, my tests all run fine now - even with Gradle.
from curator.
Has anyone tried with the latest JARs?
from curator.
As I haven't heard back on this I am closing it.
from curator.
FWIW, it didn't work with master as of a week ago and doesn't work with Curator 1.1.7. Same symptoms as earlier with hung tests. I will request a reopen when I get a chance to provide more information or an easy repro.
from curator.
Sorry :( Thanks for your patience on this.
from curator.
Related Issues (20)
- java.nio.channels.CancelledKeyException HOT 1
- java.lang.NoSuchMethodError: com.google.common.cache.CacheBuilder.build HOT 4
- adding nodes to zookeeper from local properties through archaius HOT 1
- InterProcessMutex is not releasing when called inside a future's onSuccess function. HOT 1
- Curator's Watch triggered two times for the same notification HOT 3
- Curator integration with Exhibitor-values to be provided for ExhibitorEnsembleProvider arguments HOT 1
- What's the plan for releasing changes to this? HOT 3
- org.apache.zookeeper.KeeperException$NodeExistsException: KeeperErrorCode = NodeExists HOT 3
- curator use this.client.create().creatingParentsIfNeeded().withMode(CreateMode.PERSISTENT).forPath(path, data); but I find zk didnot have this node. HOT 2
- Link in wiki is broken HOT 1
- Examples Link in Table of Contents leads to 404 HOT 2
- NoSuchMethodError exception HOT 2
- Curator connecting to a secured SASL zookeeper HOT 1
- Background operation retry gave up HOT 1
- ..
- The result of event.getPath() in BackgroundCallback confused me
- Missing method declaration addAuthInfo
- TestingServer cannot start, it always throw FailedServerStartException
- curator 5.3 connect docker zookeeper cluster
- the parent node never delete cause thousands of parent node
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from curator.