Coder Social home page Coder Social logo

Comments (4)

cakrit avatar cakrit commented on July 28, 2024

Based on this, I saw that apiVersion is a mess in our helmchart:

templates/clusterrolebinding.yaml:apiVersion: rbac.authorization.k8s.io/v1
templates/clusterrole.yaml:apiVersion: rbac.authorization.k8s.io/v1
templates/configmap.yaml:apiVersion: v1
templates/configmap.yaml:apiVersion: v1
templates/daemonset.yaml:apiVersion: apps/v1
templates/ingress.yaml:apiVersion: extensions/v1beta1
templates/serviceaccount.yaml:apiVersion: v1
templates/service.yaml:apiVersion: v1
templates/statefulset.yaml:apiVersion: apps/v1beta2

I don't know enough to understand how many different settings we need, but it looks like we should have all the necessary values in values.yaml and document them on the README. Is it something you'd be willing to do @happysalada ?

from helmchart.

happysalada avatar happysalada commented on July 28, 2024

it looks like from the deprecation notice
that ingress.yaml api version should be replaced with
networking.k8s.io/v1
and that statefulset.yaml api version should be replaced with
apps/v1
the minimum kubernetes version supported should be updated to 1.9.

making it configurable would be to support kubernetes 1.8. Do you guys have strong feelings about it?
(I see this as one less thing to remember to delete in the future, so potentially reduce the maintenance burden)

from helmchart.

cakrit avatar cakrit commented on July 28, 2024

The key thing here is that people shouldn't have to pass an entire config file to override something that may be different from one user's environment to another. So making the apiVersion configurable seems like a one-way street to me but again, I'm no expert. Let's see if we get any more comments here in the next few days.

from helmchart.

cakrit avatar cakrit commented on July 28, 2024

This was fixed by #57 and we just increased the minimum required version in README.md to be consistent with the first appearance of statefulset in api/v1.

from helmchart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.