overwhelmed by error logs about passport

[kamilmysliwiec]

Maybe we should change it from .error() to .debug() just so it's easy to turn it off (especially in prod)? 🤔

[kamilmysliwiec]

Fixed in 9.0.3. If anyone needs more verbose logging they can just override the handleRequest method.

[sezanzeb]

I wish this was changed to .debug() instead. The proposed alternative of monkey-patching it is considered bad practice afaik...

Having to

1. debug into passport
2. patch a method of a third-party library, which potentially breaks with the next release, with the patch not even having access to authLogger

is very impractical. Please consider #1251 one more time, it was writing debug logs.

[sezanzeb]

If anyone needs more verbose logging they can just override the handleRequest method.

The proposed alternative of monkey-patching it is considered bad practice afaik...

I misunderstood this, handleRequest can be overwritten in the class inheriting from AuthGuard(...) as far as I can tell, no monkey-patch required.

I would still prefer a debug log which is there by default. Without your remark I wouldn't have realized that this can be overwritten in my own guard. I think I'll give it a try next week though in the meantime.

[TrejGun]

thanks a lot

[kamilmysliwiec]

This is documented here https://docs.nestjs.com/recipes/passport#extending-guards