nestjs / nestjs.com Goto Github PK

Some of the resources in your homepage (mostly fonts) are requested in an infinite loop.

The landing page of nestjs.com website has a live preview running in StackBlitz.

The src/app.controller.spec.ts unit test is failing:
https://stackblitz.com/edit/nestjs-typescript-starter-pcysqn?file=src%2Fapp.controller.spec.ts

Currently:

describe('getHello', () => {
    it('should return "Hello World!"', () => {
      const appController = app.get<AppController>(AppController);
       // NOTE: Attempting to access the getHello() service method directly (does not exist on appController).
       expect(appController.getHello()).toBe('Hello World!');
    });
});

Suggested change:

describe('getHello', () => {
    it('should return "Hello World!"', () => {
      const appController = app.get<AppController>(AppController);
      // NOTE: Change the expect to check for valid object response using render() method
      expect(appController.render()).toEqual({ message: 'Hello World!' });
    });
});

The Codesandbox.io example on the start page is kinda questionable. The app.controller.ts does inject the AppService, but does not call anything from it, making it unneeded.

@Controller()
export class AppController {
  constructor(private readonly appService: AppService) {}

  @Get()
  render(@Res() res: Response) {
    res.sendFile(`index.html`, { root: __dirname + '/..' });
  }
}

I understand that you probably want to render the index.html so it looks more appealing. But maybe we should consider an example which actually uses a service, so the user better understands the benefits of NestJS? Maybe the app service returns a static array of benefits of NestJS which then get rendered by the index.html?

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency node to v18.19.1
• chore(deps): update dependency node to v20

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Even though your .htaccess seems to be configured correctly (= it should redirect http to https), I can still access it through http://nestjs.com (does not redirect to HTTPS)

In the docs, it says that a redis store on the CacheModule must be set up like this:

@Module({
  imports: [
    CacheModule.register<RedisClientOptions>({
      store: redisStore,

      // Store-specific configuration:
      socket: {
        host: 'localhost',
        port: 6379,
      },
      isGlobal: true
    }),
  ],
  controllers: [AppController],
})

but when the service is manually injected:

constructor(@Inject(CACHE_MANAGER) private cacheManager: Cache) {}

it gives an instance of the In Memory Cache

I think this is a documentation issue because when i set up the CacheModule in this way without the socket object:

@Module({
  imports: [
    CacheModule.register({
      store: redisStore,
      host: 'localhost',
      port: 6379,
      isGlobal: true
    }),
  ],
  controllers: [AppController],
})

it works as expected.

This issue was reproduced with this environment:

• node: 16.14.2
• @nestjs/core: 8.1.1
• cache-manager: 3.6.1
• cache-manager-redis-store: 2.0.0

When visiting https://www.nestjs.com/ there is an SSL error.

You should either buy a valid cert for the www domain or fix your config to redirect to non www.

Didn't know where else to submit the issue

You're welcome :-)

Bug Report

Sponsors/Partners section is not fully visible

Current behavior

Expected behavior

All thee sponsors should be visible

Possible Solution

Adding a margin on the container CSS class may solve the problem.

Environment

MacOS Catalin 10.15.3
Chrome Version 85.0.4183.121 (Official Build) (64-bit)

Edit: can be closed
Moved to: nestjs/courses.nestjs.com#57

https://realfavicongenerator.net/favicon_checker?protocol=https&site=nestjs.com%2F#.YBnDVugzaMo

Just noticed, that content from this page is missing.
https://docs.nestjs.com/techniques/cookies