Support of multiple endpoints about graphql

[kamilmysliwiec]

Since 5.1.0 you can restrict modules that should be included in the lookup process. For instance, if you want only resolvers from CatsModule and DogsModule to be included, simply pass them into include array:

GraphQLModule.forRoot({
    typePaths: ['./**/*.graphql'],
    include: [CatsModule, DogsModule],
}),

[kamilmysliwiec]

Thanks for repo @Rockson. Just fixed the issue, update your graphql package into 5.3.1!

[krivochenko]

There is one more problem. Before I have used GraphQLFactory.createSchema, for create schema with custom settings.

const typeDefs = this.graphQLFactory.mergeTypesByPaths('src/admin/**/*.graphql');
const resolverValidationOptions: IResolverValidationOptions = {allowResolversNotInSchema: true};
const schema = this.graphQLFactory.createSchema({typeDefs, resolverValidationOptions});

But for now this method dropped.

[krivochenko]

So, I have two modules: SiteModule and AdminModule. Each of them imports GraphQLModule. AdminModule also imports AuthModule with some, for example, AuthResolver in providers. SiteModule sees AuthResolver too, but in *.graphql files inside SiteModule there isn't mutation which exists in AuthResolver.

For now if in root-module I import so:

imports: [
  SiteModule,
  AdminModule,
],

I get error: Error: "Mutation" defined in resolvers, but not in schema. If I change order:

imports: [
  AdminModule,
  SiteModule,
],

I don't get errors during start of application, but I get 404, when I try to get /site.
I think we need a way to pass resolverValidationOptions here or reimplement ResolversExplorerService.

[krivochenko]

@kamilmysliwiec thanks for your work! I think, in some cases include property can be useful, but not in my. Let's imagine, we have CatsModule with CatsResolver. In CatsResolver there is queries for getting one or many cats. Also in the same resolver there is a mutation for editing of cat. Queries enabled for all users, but mutation only for administrators. So we don't need include information about mutation in schema of public API, but we have to include CatsModule for both endpoint.

[Rockson]

@kamilmysliwiec I Can't make it work with forRootAsync

This works

GraphQLModule.forRoot({
    typePaths: ['./admin/**/*.graphql'],
    include: [AdminModule],
    path: '/admin'
}),
GraphQLModule.forRoot({
    typePaths: ['./client/**/*.graphql'],
    include: [ClientModule],
    path: '/client'
}),

this doesn't, only the admin endpoint is available

    GraphQLModule.forRootAsync({
      imports: [ConfigModule],
      useExisting: AdminGqlConfigService,
    }),
    GraphQLModule.forRootAsync({
      imports: [ConfigModule],
      useExisting: ClientGqlConfigService,
    }),

GqlConfigs: https://gitlab.com/fabio.rizzello.lav/nest-graphql-multiple-endpoints-forRootasync-issue/blob/master/src/app/GqlConfigService.ts

ConfigModule: https://gitlab.com/fabio.rizzello.lav/nest-graphql-multiple-endpoints-forRootasync-issue/blob/master/src/app/config.module.ts

Here is the demo repo:
https://gitlab.com/fabio.rizzello.lav/nest-graphql-multiple-endpoints-forRootasync-issue
Start the server: /gqladmin is available but /gqlclient returns 404

I'm using nest 5.3.0

[kamilmysliwiec]

Have you tried updating all packages to recent patch versions?

[Rockson]

My package json

    "@nestjs/common": "^5.3.7",
    "@nestjs/core": "^5.3.7",
    "@nestjs/graphql": "^5.3.0",

I removed node_modules and then installed dependencies again

The problem persists

[Rockson]

@kamilmysliwiec
Has I've written in gitter, I think there is a problem when including the endpoint's modules

Here is the repo updated https://gitlab.com/fabio.rizzello.lav/nest-graphql-multiple-endpoints-forRootasync-issue

Is similar to the previous one I've only implemented the resovler viewer inside the clientResolver
https://gitlab.com/fabio.rizzello.lav/nest-graphql-multiple-endpoints-forRootasync-issue/blob/master/src/gql/client/client.resolver.ts
Looks like nest doesn't register the resolver because the function isn't called

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.