Comments (5)
Are resolves required when skipResolverArgs
is set to false?
from graphql.
skipResolverArgs: false
export interface IMutation {
signIn(login: string, password: string): User | Promise<User>;
signUp(): User | Promise<User>;
}
So yes they are required
from graphql.
Would you like to create a PR for this issue?
from graphql.
Would you like to create a PR for this issue?
"I will have the opportunity to delve into this only next weekend; unfortunately, I haven't had the chance to be a contributor to NestJS before."
from graphql.
@kamilmysliwiec I found the issue, can some just create PR according to the rules?
File: packegs/graphql/graphql-ast.explorer.ts
Method: toPropertyDeclarationStructure
Line: 317
Current code
return {
name: propertyName,
type: this.addSymbolIfRoot(type),
hasQuestionToken:
!required || (item as FieldDefinitionNode).arguments?.length > 0,
};
I think that the correct way is not to look on arguments array at all
return {
name: propertyName,
type: this.addSymbolIfRoot(type),
hasQuestionToken: !required,
};
from graphql.
Related Issues (20)
- Enabling ts-morph v20.x HOT 1
- MappedType PartialType throws error when using option decorator factory input HOT 7
- Using multiple `@ArgsType()` classes combines those arguments into one object and assigns it to all parameters which are an `@ArgsType` HOT 1
- Support for namespacing queries and mutations
- Always response Cannot return null for non-nullable field level2.level3 for nested resolver HOT 1
- GraphQL endpoints are not protected by the global Guards. HOT 2
- Nest can't resolve dependencies of the ApolloDriver. HOT 2
- TypeError: this.graphQlFactory.mergeWithSchema is not a function HOT 1
- If the sortSchema option is true, you want to sort the types, but not the fields. HOT 1
- CLI doesn't register object union with null HOT 1
- Add jsdoc for `debug` and `introspection` in `GraphQLModule` HOT 5
- TypeScript definitions generated with wrong case HOT 2
- `GraphQLModule` should throw an error if schema files are not found HOT 2
- Expose GraphQLModule options and gqlSchemaHost to support Serverless
- How to send partial data with error object using @Context
- CustomScalar parseLiteral doesn't allow null return type HOT 2
- Unable to Specify forRoutes Argument When Assigning Middleware to '/graphql' Endpoint
- ResolveField shouldn't be called when the field already has a value HOT 1
- Support for Custom Fields Decorators in Mapped types
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql.