Coder Social home page Coder Social logo

Comments (5)

juandav avatar juandav commented on August 20, 2024 1

PR please

from mailer.

juandav avatar juandav commented on August 20, 2024 1

thank you.

from mailer.

rafaelbatistamarcilio avatar rafaelbatistamarcilio commented on August 20, 2024

I just create an index.d.ts on the @nest-modules/mailer directory and everything works fine.

Inside the @nest-modules/mailer/dist exists some definition files. The index.d.ts file is in the wrong directory (@nest-modules/mailer/dist/index.d.ts)?

from mailer.

rafaelbatistamarcilio avatar rafaelbatistamarcilio commented on August 20, 2024

Another definition error in ISendMailOptions, template option is not recognized

image

The ISendMailOptions interface is extending SendMailOptions. It doesn't have to extend MailerSendMailOptions?

I changed the heritage and everything works fine.

image

If that changes are correct can i open an PR ? 😃

from mailer.

rafaelbatistamarcilio avatar rafaelbatistamarcilio commented on August 20, 2024

@juandav that's my first contribution for an open source project, any tips about commit messages, branch names, etc are very welcome! Thanks a lot for the opportunity of contribute with the project.

from mailer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.