Comments (7)
@iMerica I've also noticed this now and again. I'll look into it, too. Thanks!
from react-photo-gallery.
@iMerica i've noticed this happens to me when the image is in the last row and there arent 3 images. it could be that the image is not high res enough to deal with the larger size it takes on due to the fact there arent enough images to fill the row. i should probably prevent this last row resizing the images.
from react-photo-gallery.
@iMerica can you tell me if this only happens when an image is in the last row of a gallery?
from react-photo-gallery.
Yeah that sounds right. From what I recall it affected the last row.
from react-photo-gallery.
@iMerica I believe the aspect ratio is still preserved, rather its being stretched too big to fit the whole row so the resolution looks bad. i think the solution is that in the case when the last row of the gallery has fewer images than the rest, to not stretch it (or them) to fit the whole row but instead have it act as if there are in fact the same amount of images in that row so as to maintain consistency in size with the other images. So there will be whitespace instead.
from react-photo-gallery.
White space is preferable to image degradation so I think that works 👍 . It would be good to first check if the image width is wide enough to stretch across the viewport width. Otherwise, display full res + white space.
Edit: Nevermind
from react-photo-gallery.
@iMerica that could be something to consider for panorama type images. but that's been an issue i've always had where i'd like panoramas to be on their own row, but ill think about that later.
from react-photo-gallery.
Related Issues (20)
- Adjustable margins at the library level? HOT 3
- Lightbox image not centering HOT 3
- Adding attributes
- Handing images when they are missing
- Empty markup rendered using Jest and testing-library HOT 2
- React 17.x support HOT 6
- Rows Gallery Layout problem HOT 1
- Images become stretchy vertically on iPhone Safari HOT 6
- how to change number of image per row?
- How to load many images locally
- This Does not have support for react 17.0 HOT 2
- Additional props for photo
- Is is possible to cover images in gridview? HOT 1
- Caption, and hi-res download
- Add gap property to Gallery HOT 6
- How to add style to images?
- Custom dynamic columns example does not load
- Max image container width and height
- Defaultprops warning
- Can I use it with Angular?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-photo-gallery.