Coder Social home page Coder Social logo

Comments (7)

neptunian avatar neptunian commented on August 27, 2024

@iMerica I've also noticed this now and again. I'll look into it, too. Thanks!

from react-photo-gallery.

neptunian avatar neptunian commented on August 27, 2024

@iMerica i've noticed this happens to me when the image is in the last row and there arent 3 images. it could be that the image is not high res enough to deal with the larger size it takes on due to the fact there arent enough images to fill the row. i should probably prevent this last row resizing the images.

from react-photo-gallery.

neptunian avatar neptunian commented on August 27, 2024

@iMerica can you tell me if this only happens when an image is in the last row of a gallery?

from react-photo-gallery.

iMerica avatar iMerica commented on August 27, 2024

Yeah that sounds right. From what I recall it affected the last row.

from react-photo-gallery.

neptunian avatar neptunian commented on August 27, 2024

@iMerica I believe the aspect ratio is still preserved, rather its being stretched too big to fit the whole row so the resolution looks bad. i think the solution is that in the case when the last row of the gallery has fewer images than the rest, to not stretch it (or them) to fit the whole row but instead have it act as if there are in fact the same amount of images in that row so as to maintain consistency in size with the other images. So there will be whitespace instead.

from react-photo-gallery.

iMerica avatar iMerica commented on August 27, 2024

White space is preferable to image degradation so I think that works 👍 . It would be good to first check if the image width is wide enough to stretch across the viewport width. Otherwise, display full res + white space.

Edit: Nevermind

from react-photo-gallery.

neptunian avatar neptunian commented on August 27, 2024

@iMerica that could be something to consider for panorama type images. but that's been an issue i've always had where i'd like panoramas to be on their own row, but ill think about that later.

from react-photo-gallery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.