undefined method `join' for nil:NilClass when missing originations in config about peering

[bswinnerton]

Looks like the problem is in the originations section, it's expecting a v4 key:

diff --git a/config/test.yml b/config/test.yml
index 374afc3..958f461 100644
--- a/config/test.yml
+++ b/config/test.yml
@@ -24,6 +24,7 @@ preferred_source:

 # The prefixes being originated by this router
 originations:
+  v4: []
   v6:
     - '2a0e:8f02:201a::/48'
     - '2a0e:8f02:201b::/48'

Definitely seems like a bug. Even if you add in the empty array there it still will result in a malformed BIRD config (an empty array):

define ORIGINATED_PREFIXES_4 = [
  
];

define ORIGINATED_PREFIXES_6 = [
  2a0e:8f02:201a::/48,
  2a0e:8f02:201b::/48
];

define OUR_INTERNAL_PREFIXES_4 = [
  
];

define OUR_INTERNAL_PREFIXES_6 = [
  2a0e:8f02:201a::/48+,
  2a0e:8f02:201b::/48+
];

Let me put together something to support missing originations.

[bswinnerton]

👋 @samip5, this should now be resolved in the latest version on master. Mind giving this another try?

[samip5]

@bswinnerton, the actual generation works now, but it still generates for example rules for GLOBAL_BLACKLIST_4, which I think shouldn't be there if you got no IPv4 related things as the config reload will fail due to no GLOBAL_BLACKLIST_4.

Other thing that should also be commented out or not inserted at all are in the function is_own_prefix, as seen here:
https://github.com/neptune-networks/peering/blob/master/templates/bird.conf.erb#L210-L212 and https://github.com/neptune-networks/peering/blob/master/templates/bird.conf.erb#L228-L230. Those will fail with undefined variable errors.