Coder Social home page Coder Social logo

Comments (5)

scohen avatar scohen commented on June 28, 2024 1

Maybe the changes in the commit is intended to conform to specifications of LSP, but they looks like not still enough.
(Specs doesn't require sorting of text-edits)

For what it's worth, the spec specifically says that the order of edits matters. The language server I run sends them in a specific order, and they work fine in VSCode. Neovim is the only client that we've had this issue with.

from neovim.

kyoh86 avatar kyoh86 commented on June 28, 2024

Just to be clear: I am not sure if the problem @scohen is facing is the same as the one caused by the compatibility with efm-langserver.

from neovim.

scohen avatar scohen commented on June 28, 2024

My take is that the client shouldn't be reordering edits, neovim's client does. Right now, my LS doesn't have a problem with neovim, the commits mentioned in the bug fixed the problems we were having, but I felt that was not a correct fix.

from neovim.

kyoh86 avatar kyoh86 commented on June 28, 2024

Maybe it should be reported as another issue.

from neovim.

geril2207 avatar geril2207 commented on June 28, 2024

I also have kind of the same problem with tsserver after 2ce4a4d, #29286

from neovim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.