Add background to StatusLineNC when termguicolors is disabled about neovim

[justinmk]

For non-truecolor, I think we should consider underline for the StatusLineNC. I can accept the arguments against it for truecolor, but not for 256 color case.

[echasnovski]

Either is fine with me. Underline is a big help. IMO bold is not visually helpful so it makes no difference (though "bold" in ANSI colors can actually mean a different color).

OK, bold,underline it is then.

[echasnovski]

The problem for default color scheme with 'notermguicolors' is that there is no good (robust and visually accessible) way to highlight non-active statusline to be distinguishable both from text and active statusline. The best compromise in my opinion is already present and it uses bold text in non-active statusline.

I'd suggest that the solution here is for users to adjust StatusLineNC to fit their taste. For example: hi StatusLineNC cterm=bold,underline (underline is used very sparingly due to not having good universal support) or hi StatusLineNC ctermfg=12 (to highlight with different color).

[echasnovski]

For non-truecolor, I think we should consider underline for the StatusLineNC. I can accept the arguments against it for truecolor, but not for 256 color case.

Using cterm=underline is not a problem for me as far as aesthetic goes ('notermguicolors' case is more like "make as good as is reasonable" for me).

The main concern was that if terminal emulator does not support 'termguicolors' then it might as well not support underline.

So I guess the question is should it be cterm=bold,underline (more visible than necessary but safer for compatibility) or just cterm=underline (less noisy but less compatible)?

[justinmk]

So I guess the question is should it be cterm=bold,underline (more visible than necessary but safer for compatibility) or just cterm=underline (less noisy but less compatible)?

Either is fine with me. Underline is a big help. IMO bold is not visually helpful so it makes no difference (though "bold" in ANSI colors can actually mean a different color).