async from plenary about neogit

[TimUntersberger]

And maybe in return you could consider contributing your notification library to plenary? It's really quite lovely, and I'd love to use it as a vim.notify provider...

I don't think there is any point, because the library is already part of neovim ui

[oberblastmeister]

I am also working on async await jobs as a follow up pr.

[oberblastmeister]

async await jobs are here! link

[mjlbach]

I think depending on plenary is good, as much of plenary will likely make it into core at some point, and the async PR has a high likelihood of being merged.

[oberblastmeister]

async await was merged!

[TimUntersberger]

I also feel like depending on plenary is a none issue, since a lot of plugins are already using the "library". Like @mjlbach said, I also think that most of the plenary stuff will make it into core (mostly because tj is the owner of the library).

Changing from our own solution to the async lib from plenary is probably a good idea 👍

[clason]

And maybe in return you could consider contributing your notification library to plenary? It's really quite lovely, and I'd love to use it as a vim.notify provider...

(Apropos: Not worth its own issue, but it'd look nicer if the notification highlight groups were linked to standard highlight groups -- like MoreMsg, WarnMsg, and ErrMsg -- rather than specific colors. I haven't tested it but from the code it looks like these are set unconditionally, so they would override the ones from a user's init.vim or color scheme should they set them there?)

[RianFuro]

@oberblastmeister thanks for all the work you put into it, looks amazing!