Commit Popup about neogit

[TimUntersberger]

Maybe listing only available commands in commit popup could avoid useless issues and make things clearer to the user.

I also noticed this problem. After #131 is merged this is fixed.

[n3wborn]

Toggling a flag in the commit popup doesn't seem to do anything, or I'm misunderstanding what pressing tab on one of those lines means.

Nvim nightly / neogit up-to-date

Tabs on an option works for me, same if I type -u for upstream for exemple

[hdonnay]

Ah, sorry, I was thrown off by the trailer not being there while editing, as if I'd run git commit -s on the command line. I do see that line in the command history and the trailer in the commit with git show. I must have been mistaken before when I thought it was missing. Thanks for the help!

[vendion]

When trying to do a commit using the verbose flag -v, there is no inline diff of the files that are about to be committed.

Also is it possible to set defaults for the commit popup? I like doing commits with the -v and -s flags and having to press them every time can get annoying.

[n3wborn]

Hi !
As a newcomer I was about to fill an issue because I tried to "Fixup" a commit in the previous one but nothing happened when after "c" I hit "f" (same for f/s/S).

I though this was bug or me not being smart enough to understand how to do a fixup. I first asked on r/neovim and I've been told to fill an issue so that I and other people in the same situation could benefit from the answer.

But now that I see this issue I can see that Fixup/Squash/etc is not possible yet. Maybe listing only available commands in commit popup could avoid useless issues and make things clearer to the user.

I've just switched from fugitive cause I really love the way Neogit works, so thank you :)

[hdonnay]

Toggling a flag in the commit popup doesn't seem to do anything, or I'm misunderstanding what pressing tab on one of those lines means.

[TimUntersberger]

@hdonnay can you give me an example?

[hdonnay]

On neogit 3226b98 and neovim 0.5.0 (from Fedora 34) hitting the -s (signoff) toggle results in a message where the sign-off trailer is not present.

[TimUntersberger]

@hdonnay I cannot reproduce this. If you open your command history, does it have the following line?

git commit --file=.git/NEOGIT_COMMIT_EDITMSG --signoff

[d-miketa]

Hey, really enjoying this functionality. :)

I noticed one inconsistency though: when committing through :Neogit commit, I usually don't see a list of staged files etc to provide context for the commit message – but sometimes it appears. Committing via the UI at :Neogit always produces the list.

[TimUntersberger]

I usually don't see a list of staged files etc to provide context for the commit message

We are using the output of git commit --dry-run for that. I haven't reproduced this yet. If you encounter this again try running the command and see whether it includes the diff.

[d-miketa]

I haven't encountered the error at all today, so perhaps one of your recent commits fixed it? :)

Thank you for the amazing plugin! Using it daily.

[pbogut]

Not sure if its right place but its related. I don't get context for commit either, but only sometimes, not sure what it depends on, is all right in some projects in others its not.

What I can tell for sure is that when it doesn't work git commit --dry-run returns Error 128 in Neogit command log (after checking with $). Error 128 is fatal: this operation must be run in a work tree. When I run it manually :execute('!cd ' . getcwd() . ' && git commit --dry-run') it runs fine.

It looks like Neogit sometimes run this command outiside git tree.

[TimUntersberger]

@pbogut can you create a seperate issue for this? Thank you for finding a problem 👍

[pbogut]

@TimUntersberger I've tried to reproduce it with minimal config and it looks like it was my config. Sorry for bothering you. I will try to find out which part of my config was causing the issue and if it's not me being dumb (unlikely) I will create issue.