COMMIT_EDITMSG save does not create commit on `:wq` about neogit

[bagnaram]

I switched to the branch you mentioned and it works. Sweet!

Yeah you're right about how the autocmd handles different types of buffer closure states. I recall some sort of thing glancing at the docs long ago.

Thanks for maintaining this awesome plugin! It's a must-have coming from emacs!

[bagnaram]

I see the same result with the latest change. I will mess with it when I have some more time but for now I will settle for my autocmd workaround. Thanks!

[CKolkey]

Yea, in order for us to be able to abort, and for some other reasons, we rely on a BufUnload autocmd to handle some cleanup behind the scenes. But, this means :wq won't work. :w then :q. You can also use q or <c-c><c-c> to submit the commit - those can be remapped too.

The reason it hangs like you see is complicated.. Mostly to do with this: https://github.com/NeogitOrg/neogit/blob/master/lua/neogit/client.lua

Anyways, this isn't a "bug", per-sey, but I'll leave this open for visibility/feedback.

[CKolkey]

You can try this branch and let me know if that works. The documentation on autocmds isn't the best, but I think that should get called with :wq

[bagnaram]

I take that back 😅 It appears to have worked due to that race condition mentioned earlier. Subsequent commit attempts are failing.

[bagnaram]

I wonder if it has to do with some sort of internal vim race condition? Now I know how to get around it though using CTRL-C+CTRL-C

[bagnaram]

it's sort of glitchy but I think I got it working with autocmd Filetype NeogitCommitMessage cmap <buffer> <silent> wq w!<CR><c-c><c-c>

It's the muscle memory that is failing me!

[CKolkey]

I changed the test branch to use the WinClosed event instead of BufUnload. Maybe it is some race condition, or.. I donno. It seems like it's some combination of saving and closing in the same action that messes it up. I'm having trouble reproducing it, to be honest. But I would like this to work.

[lechat]

it's sort of glitchy but I think I got it working with autocmd Filetype NeogitCommitMessage cmap <buffer> <silent> wq w!<CR><c-c><c-c>

Please don't forget about :x as well!