2.1.8 => 2.3.1 upgrade failure about docker-neo4j

[domdavis]

Further investigation may point to the way the DB is being shut down within docker:

• 2.1.8 running directly on the box -> 2.3.1 running directly on the box works fine
• 2.1.8 running in docker -> 2.3.1 running directly on the box errors

However, if you go 2.1.8 in Docker, then run 2.1.8 locally against that DB you get the following in the logs:

Detected incorrectly shut down database, performing recovery..

Running 2.3.1 locally now works fine, as does running it in Docker.

I suspect the issue is that docker stop (in the vinelab image at the very least) isn't shutting down Neo4j in a nice way which is leaving the DB in a state where it can't be upgraded.

[domdavis]

Now I've got a workaround on this it's no longer a blocker for me.

[benbc]

@domdavis Ah! Well spotted -- I should have thought of that.

There is a change in Neo4j 2.3.0 which allows Docker to shut it down cleanly. All earlier versions of Neo4j have a problem where Docker has to kill them at shutdown. I wasn't aware that this would cause a problem with upgrades, but I'm sure it's what you're seeing.

We don't support running Neo4j under Docker before 2.3.0. I recommend that you use the latest official image, neo4j.

I'm going to close this now, on that basis. Please let me know if you have any more questions.