regex for 'excludes' option? about offline-plugin

[NekR]

Hi! In excludes property and in most others you can just use pattern matching, e.g. excludes: 'icon-*' will exclude everything what starts with icon-.

[jackyon]

hi @NekR, thx for reply, I have tried that before, but seems not working, now I figure out the problem might be from FaviconsWebpackPlugin, the icons were generate by this plugin, I found the excludes option works every pattern except 'icons-*'

my webpack plugin config:

new FaviconsWebpackPlugin({
    logo: './app/public/react-logo.png',
    title: 'react app'
}),
new OfflinePlugin({
    publicPath: '/assets/',
    relativePaths: false,
    excludes: ['icons-*', '**/.*']
}),

[NekR]

@jackyon yep, might be related to that plugin, depends on how it's implemented. I'll look into it. Thanks for reporting!

[NekR]

Okay, this seems to be a problem of minimatch, its wildcards work in some weird way, e.g. icons-* doesn't match dirs and icons-*/** doesn't match hidden files (files with leading dot, e.g. .cache). So you have to use something like this (it works for me):

excludes: ['icons-*/{*.*,.*}'],

But I guess it's better to switch off from minimatch (in future) so something else which works better here.

... or I just have to properly configure minimatch to work in this cases.

[jackyon]

@NekR , thx for your solution, it works!

[NekR]

Great! Closing then. I'll think on how to improve pattern matching here.