Coder Social home page Coder Social logo

Comments (11)

KiChjang avatar KiChjang commented on June 3, 2024 1

@gitcoinbot Yes, currently working on writing tests for the collection classes.

from near-sdk-as.

gitcoinbot avatar gitcoinbot commented on June 3, 2024

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 266 years, 3 months from now.
Please review their action plans below:

1) kichjang has been approved to start work.

These functions look like a very straightforward API change. As I understand it, it is a matter of adding host functions to the contract registry, and making new APIs for the collection classes to utilize them. The real difficulty here is ensuring that all the collection classes are ensuring adequate test coverage and that they all pass correctly.
2) monder022 has applied to start work (Funders only: approve worker | reject worker).

I'll do my best anything! But please let me guide me
3) pathleader has applied to start work (Funders only: approve worker | reject worker).

Get a team, and work with due diligence in the discharge of my duty

Learn more on the Gitcoin Issue Details page.

from near-sdk-as.

willemneal avatar willemneal commented on June 3, 2024

@KiChjang left you a comment on gitcoin.

from near-sdk-as.

KiChjang avatar KiChjang commented on June 3, 2024

@willemneal I'm trying to understand env.ts, how are the functions there being hooked up by the host?

from near-sdk-as.

willemneal avatar willemneal commented on June 3, 2024

They are indirect calls to global functions. This way the declared imports are compiled only when it's called.

I would check out storage.ts to start.

from near-sdk-as.

KiChjang avatar KiChjang commented on June 3, 2024

@willemneal Ok, what I am trying to understand here is if I can just add export function return_raw(register_id: u64): void; to env.ts and expect it to work, and I don't think I can. I think the problem here is that I don't know where and how the global functions are defined.

from near-sdk-as.

willemneal avatar willemneal commented on June 3, 2024

Sorry if it wasn't clear but you add a function in the name space and it is not a new import from the host. You will write it; it's in env because it's low level and a helper function.

You don't need to worry about adding any new imports.

from near-sdk-as.

gitcoinbot avatar gitcoinbot commented on June 3, 2024

@KiChjang Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

from near-sdk-as.

willemneal avatar willemneal commented on June 3, 2024

@KiChjang I'd recommend in the future immediately creating a PR that is a work in progress and then pushing to that often. At the end of the PR I'll squash your commits anyway.

from near-sdk-as.

KiChjang avatar KiChjang commented on June 3, 2024

@willemneal Per your request, I made PR that doesn't contain any tests yet. It'd be great if you can also take a look at it and see if I'm on the right track.

from near-sdk-as.

gitcoinbot avatar gitcoinbot commented on June 3, 2024

@KiChjang Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

from near-sdk-as.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.