Coder Social home page Coder Social logo

There seems to be a bug in the comparison of the Gridded/run_*/CHANOBS files: some of the files are not found. about wrf_hydro_nwm_public HOT 3 CLOSED

jmccreight avatar jmccreight commented on June 19, 2024
There seems to be a bug in the comparison of the Gridded/run_*/CHANOBS files: some of the files are not found.

from wrf_hydro_nwm_public.

Comments (3)

tjmills avatar tjmills commented on June 19, 2024

I believe this is the cause:

This logic is responsible for the None print statements
https://github.com/NCAR/wrf_hydro_nwm_public/blob/master/tests/test_2_regression.py#L107-L114

    ```if all(v is None for v in chanobs_diffs):
        has_diffs = False
    else:
        has_diffs = True
        #chanobs_diffs.remove(None)
        for the_diff in chanobs_diffs[0:5]:
            with capsys.disabled():
                print(the_diff)```

I believe whats happening is that there is a diff but in a file that is not one of the first 5 in the list. We can resolve this by stripping all None values out of the list prior to the print statements

from wrf_hydro_nwm_public.

tjmills avatar tjmills commented on June 19, 2024

This I believe would fix it, will submit a PR with it when I have a chance

if all(v is None for v in chanobs_diffs):
        has_diffs = False
    else:
        has_diffs = True
        only_diffs = [the_diff for the_diff in chanobs_diffs if the_diff is not None]
        for the_diff in only_diffs[0:5]:
            with capsys.disabled():
                print(the_diff)

from wrf_hydro_nwm_public.

tjmills avatar tjmills commented on June 19, 2024

This has been resolved as part of the testing refactor but I did not close with PR as I should have. Closing now

from wrf_hydro_nwm_public.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.