Coder Social home page Coder Social logo

Comments (2)

andersy005 avatar andersy005 commented on August 17, 2024

It appears that the issue is in_apply_nan_mask(). This function assumes that all dimensions should be used:

weights = xr.DataArray(np.ones(dims_shape), dims=op_over_dims)
weights = _apply_nan_mask(weights, x, y)

def _apply_nan_mask(weights, x, y=None):
# If y is specified, make sure x and y have same shape
if y is not None and isinstance(y, xr.DataArray):
assert x.shape == y.shape
valid = x.notnull() & y.notnull()
else:
valid = x.notnull()
# Apply nan mask
return weights.where(valid)

As a consequence, the shape of the returned weights is always equal to the input array's shape, even when the user wants to apply the operation along a particular dimension.

To fix this, we will need to come up with a way of doing valid = x.notnull() while taking into consideration dimensions supplied by the user.

from esmlab.

andersy005 avatar andersy005 commented on August 17, 2024

Fixed in #97

from esmlab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.