Coder Social home page Coder Social logo

Comments (4)

jhpark816 avatar jhpark816 commented on May 20, 2024

ExtendedBTreeGetOperationImpl도 interface 지정이 잘못 되어 있는 것 같습니다..
ExtendedBTreeGetOperation의 Callback interface는
CollectionGetOperation의 Callback interface와 argument가 다른 데, 괜찮은가요 ?

public class ExtendedBTreeGetOperationImpl extends OperationImpl
    implements CollectionGetOperation {
    . . .
}

from arcus-java-client.

whchoi83 avatar whchoi83 commented on May 20, 2024

ExtendedBTreeGetOperationImple 의 instance 를 ArcusClient class 에서 생성하는데 이때 매개변수로 넘겨주는 Callback interface 의 구현을 부분을 보면
ExtendedBTreeGetOperationImpl 은 ExtendBTreeGetOperation interface를 implements 하는 것이 맞습니다.
해당 부분의 소스는 아래와 같습니다.

    private <T> CollectionFuture<Map<ByteArrayBKey, Element<T>>> asyncBopExtendedGet(
            final String k, final CollectionGet<T> collectionGet,
            final boolean reverse, final Transcoder<T> tc) {

...
        Operation op = opFact.collectionGet2(k, collectionGet,
                new ExtendedBTreeGetOperation.Callback() {
                    TreeMap<ByteArrayBKey, Element<T>> map = new ByteArrayTreeMap<ByteArrayBKey, Element<T>>(
                            (reverse) ? Collections.reverseOrder() : null);
...
                    public void gotData(String key, byte[] subkey,
                            byte[] elementFlag, int flags, byte[] data) {
                        assert key.equals(k) : "Wrong key returned";
                        Element<T> element = new Element<T>(subkey, tc
                                .decode(new CachedData(flags, data, tc
                                        .getMaxSize())), elementFlag);
                        map.put(new ByteArrayBKey(subkey), element);
                    }
                });

from arcus-java-client.

whchoi83 avatar whchoi83 commented on May 20, 2024

commit 완료 했습니다.
리뷰 부탁드립니다.
commit : ed4ef54

from arcus-java-client.

jhpark816 avatar jhpark816 commented on May 20, 2024

code reveiw & merge 했습니다..
이슈 브랜치는 제거해도 됩니다.

from arcus-java-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.