Remove namespace keys as well with ignoreNamespace about fast-xml-parser

[Delagen]

#32

[amitguptagwl]

Umm, sorry if I'm missing some point. But I never seen namespace with attribute's value. Can you please give me some reference from w3 or wikipedia? I would be interested to know more about it as I may have to update the validator and may have to handle some negative scenarios.

[Delagen]

@amitguptagwl for example http://www.xmlplease.com/xml/attributexmlns/
Namespace can be specified as simply xmlns attribute for element cause it default for self and children and even can be specified for single attribute.
So I offer to remove xmlns attribute as well in ignoreNamespace mode.
I updated my PR to include this, tests updated. Also make Coverage only for Library code, not for tests

[amitguptagwl]

Currently when we ignoreNamespace

input XML

<xp:products xmlns:xp="http://www.xmlplease.com">
   <xp:product id="p1"/>
</xp:products>

Output JSON

{
    "products": {
        "xp": "http://www.xmlplease.com",
        "product": {
            "id": "p1"
        }
    }
}

What should be output after your changes?

[Delagen]

{
    "products": {
        "product": {
            "id": "p1"
        }
    }
}

[amitguptagwl]

I appreciate your effort for the changes. But I believe this change may impact some projects using this library. So until there are some users who want this change explicitly, we should hold this change.

Or if we think in a way that when people ignoring namespace, would it benefit them to ignore xmls attribute or not to have at all in JSON.

[Delagen]

@amitguptagwl if we remove namespaces from all elements and from all attributes, what the purpose of namespace values in output? Using this namespace urls we still cannot differ namespaced elements & attributes from plain, but can make some incosistence with attributes in output, that does not make any meaning in output

[Delagen]

@amitguptagwl
For example:
Valid XML

<root attr="value" xmlns:attr="urn:none">1</root>

Code:

parser.parse(xml,{ignoreTextNodeAttr : false, ignoreNameSpace : true})

Current output:

{"root":{"@_attr":"urn:none","#text":1}}

PR output:

{"root":{"@_attr":"value","#text":1}}

[amitguptagwl]

I agree with you.

[amitguptagwl]

Thanks you took care of tests and browser lib js file. I'll publish the changes soon.

[Delagen]

@amitguptagwl Thanks to you for offer this parser to everyone

[ahmed-sigmalux]

Did anything come of this?