Coder Social home page Coder Social logo

Comments (4)

calculuschild avatar calculuschild commented on June 17, 2024

Right now, users without an account can't use the download as txt

This is not true. All users can download as txt, whether logged in or not.

Download button is accessible while not logged in:
image

from homebrewery.

ericscheid avatar ericscheid commented on June 17, 2024

If the brew is saved then the Download option is available by first clicking the Share → View nav menu item, and then the Source → Download option. It's not obvious, but it is possible.

What is not available is the Download Brew button on a brewItem card on a /users/ page, as the brew has not been associated with a user as yet.

Similarly, there is no option to download if the brew has not yet been saved at all. Which is not unreasonable.

On the /new page, the Get PDF nav item can't also support a Download Text option because it's a http request to the server for /download/:id (and the brew only exists in localStorage, not a /edit/:id). Not unless we engineer an entirely client-side download text option (not difficult, but is forking functionality and so is architecturally unsound).

from homebrewery.

5e-Cleric avatar 5e-Cleric commented on June 17, 2024

Right, checked the edit page, but i guess they can access the share page, nvm then

from homebrewery.

calculuschild avatar calculuschild commented on June 17, 2024

That said, I don't think it would be unreasonable to make the download link visible on the edit page. It is not super obvious that it is hidden away on the share page. I'm not sure how we would best fit everything, but if there is some reorganization of the nav bar that makes sense I'm ok with that.

from homebrewery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.