Coder Social home page Coder Social logo

Comments (10)

derekcollison avatar derekcollison commented on June 12, 2024

Thanks will take a look.

from jetstream.

derekcollison avatar derekcollison commented on June 12, 2024

I see it is requesting deliverAll and deliverLast which it properly errors on, you can only chose one. But it must not clean it self up properly or something..

from jetstream.

ripienaar avatar ripienaar commented on June 12, 2024

On jsm side I will be more careful about these combos, will check tomorrow

from jetstream.

derekcollison avatar derekcollison commented on June 12, 2024

Might also be the advisory being generated.. Will check it out.

from jetstream.

matthiashanel avatar matthiashanel commented on June 12, 2024

Yes I realized that this is what is going on inside the server.
I do not explicitly set both...

In general can we improve the errors returned?
Currently we return a generic error, can we add details? (: )
This is probably a bigger issue and came up on the ngs prod slack today as well.

from jetstream.

ripienaar avatar ripienaar commented on June 12, 2024

jsm uses a starting template and merged your options with that template. I wasn’t careful to avoid impossible combos there

Regardless server needs to not do what it does. I have worked on better errors but people don’t seem to like it (myself included)

from jetstream.

derekcollison avatar derekcollison commented on June 12, 2024

I will fix server issue.

from jetstream.

derekcollison avatar derekcollison commented on June 12, 2024

ok fixed in jetstream branch.

from jetstream.

matthiashanel avatar matthiashanel commented on June 12, 2024

That seems to have done it.

from jetstream.

matthiashanel avatar matthiashanel commented on June 12, 2024

@ripienaar , I created a separate issue for the jsm library. Personally I'd fix this by making it impossible through changing the format altogether. Similar for consumer options.

from jetstream.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.