Coder Social home page Coder Social logo

Comments (5)

dmazzoni avatar dmazzoni commented on May 19, 2024 1

Yes, I'll probably be able to open it tomorrow

from zoomlayout.

natario1 avatar natario1 commented on May 19, 2024

Yes, we want to keep listening to changes in child, not just the first time.

It's not clear to me where the leak is... I thought ViewTreeObserver would die with the view.
You could unregister the listener during removeView, but I don't know if that's called in your case. Is it?

from zoomlayout.

dmazzoni avatar dmazzoni commented on May 19, 2024

Thanks for your feedback!
No, in my case removeView is not called, so I can't unregister the listener there.

from zoomlayout.

dmazzoni avatar dmazzoni commented on May 19, 2024

Anyway, regardless of its cause, the leak may be prevented by turning the anonymous layout listener into a static nested class which holds weak references to mEngine, mChildRect and the view being added.

from zoomlayout.

markusressel avatar markusressel commented on May 19, 2024

@dmazzoni Since you have already done a lot of work on this are you interested in opening a PR for this?

from zoomlayout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.